From: Kevin Hilman <khilman@kernel.org>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH stable/3.18.y] media: remove unused variable that causes a warning
Date: Tue, 25 Aug 2015 08:38:07 -0700 [thread overview]
Message-ID: <7hzj1fe5uo.fsf@deeprootsystems.com> (raw)
In-Reply-To: <55DB669D.5080501@oracle.com> (Sasha Levin's message of "Mon, 24 Aug 2015 14:46:53 -0400")
Sasha Levin <sasha.levin@oracle.com> writes:
> On 08/24/2015 02:02 PM, Kevin Hilman wrote:
>> From: Linus Torvalds <torvalds@linux-foundation.org>
>>
>> My 'allmodconfig' build is _almost_ free of warnings, and most of the
>> remaining ones are for legacy drivers that just do bad things that I
>> can't find it in my black heart to care too much about. But this one
>> was just annoying me:
>>
>> drivers/media/v4l2-core/videobuf2-core.c:3256:26: warning: unused variable ‘fileio’ [-Wunused-variable]
>>
>> because commit 0e661006370b ("[media] vb2: fix 'UNBALANCED' warnings
>> when calling vb2_thread_stop()") removed all users of 'fileio' and
>> instead calls "__vb2_cleanup_fileio(q)" to clean up q->fileio. But the
>> now unused 'fileio' variable was left around.
>>
>> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
>> (cherry picked from commit 1d11437f4fd02f9b5d3749675a1232216787dcc6)
>> Cc: <stable@vger.kernel.org> # v3.18+
>> Signed-off-by: Kevin Hilman <khilman@linaro.org>
>
> Hey Kevin,
>
> I'm afraid this isn't -stable material: it doesn't fix and actual problem
> that bothers users, so I can't take it.
OK, no worries. I wasn't clear if trival build fixes qualified.
Thanks,
Kevin
prev parent reply other threads:[~2015-08-25 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 18:02 [PATCH stable/3.18.y] media: remove unused variable that causes a warning Kevin Hilman
2015-08-24 18:46 ` Sasha Levin
2015-08-25 15:38 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hzj1fe5uo.fsf@deeprootsystems.com \
--to=khilman@kernel.org \
--cc=sasha.levin@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).