From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f52.google.com ([209.85.220.52]:36779 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755139AbbHYPiK convert rfc822-to-8bit (ORCPT ); Tue, 25 Aug 2015 11:38:10 -0400 Received: by padfo6 with SMTP id fo6so11097050pad.3 for ; Tue, 25 Aug 2015 08:38:09 -0700 (PDT) From: Kevin Hilman To: Sasha Levin Cc: stable@vger.kernel.org Subject: Re: [PATCH stable/3.18.y] media: remove unused variable that causes a warning References: <1440439336-13326-1-git-send-email-khilman@kernel.org> <55DB669D.5080501@oracle.com> Date: Tue, 25 Aug 2015 08:38:07 -0700 In-Reply-To: <55DB669D.5080501@oracle.com> (Sasha Levin's message of "Mon, 24 Aug 2015 14:46:53 -0400") Message-ID: <7hzj1fe5uo.fsf@deeprootsystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: stable-owner@vger.kernel.org List-ID: Sasha Levin writes: > On 08/24/2015 02:02 PM, Kevin Hilman wrote: >> From: Linus Torvalds >> >> My 'allmodconfig' build is _almost_ free of warnings, and most of the >> remaining ones are for legacy drivers that just do bad things that I >> can't find it in my black heart to care too much about. But this one >> was just annoying me: >> >> drivers/media/v4l2-core/videobuf2-core.c:3256:26: warning: unused variable ‘fileio’ [-Wunused-variable] >> >> because commit 0e661006370b ("[media] vb2: fix 'UNBALANCED' warnings >> when calling vb2_thread_stop()") removed all users of 'fileio' and >> instead calls "__vb2_cleanup_fileio(q)" to clean up q->fileio. But the >> now unused 'fileio' variable was left around. >> >> Signed-off-by: Linus Torvalds >> (cherry picked from commit 1d11437f4fd02f9b5d3749675a1232216787dcc6) >> Cc: # v3.18+ >> Signed-off-by: Kevin Hilman > > Hey Kevin, > > I'm afraid this isn't -stable material: it doesn't fix and actual problem > that bothers users, so I can't take it. OK, no worries. I wasn't clear if trival build fixes qualified. Thanks, Kevin