Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Harshit Agarwal <harshit@nutanix.com>
To: Phil Auld <pauld@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	Jon Kohler <jon@nutanix.com>,
	Gauri Patwardhan <gauri.patwardhan@nutanix.com>,
	Rahul Chunduru <rahul.chunduru@nutanix.com>,
	Will Ton <william.ton@nutanix.com>
Subject: Re: [PATCH v2] sched/rt: Fix race in push_rt_task
Date: Wed, 26 Mar 2025 17:57:23 +0000	[thread overview]
Message-ID: <801794EB-9075-4097-9355-76A042B62FB5@nutanix.com> (raw)
In-Reply-To: <20250326131821.GA144611@pauld.westford.csb>



> On Mar 26, 2025, at 6:18 AM, Phil Auld <pauld@redhat.com> wrote:
>> 
> 
> We've got some cases that look to be hitting this as well.
> 
> I'm a little concerned about turning some runtime checks into
> BUG_ON()s but in this case I think we are really just going to
> trap out on !has_pushable_tasks() check first and if not, pick
> a different task and don't drop the lock so it should pass the
> BUG_ON()s and fail to match the original task.  So...
> 
> Reviewed-by: Phil Auld <pauld@redhat.com>
> 

Thanks Phil for your review. Just FYI this is the link to
v3 (latest version) of this change 
https://lore.kernel.org/lkml/20250225180553.167995-1-harshit@nutanix.com/
No change here in the code w.r.t v2. I had just updated the
commit message to add stable maintainers.

Regards,
Harshit

  reply	other threads:[~2025-03-26 18:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-14 17:08 [PATCH v2] sched/rt: Fix race in push_rt_task Harshit Agarwal
2025-02-14 17:12 ` kernel test robot
2025-02-17 16:54 ` Steven Rostedt
2025-03-26 13:18   ` Phil Auld
2025-03-26 17:57     ` Harshit Agarwal [this message]
2025-03-26 18:25       ` Phil Auld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=801794EB-9075-4097-9355-76A042B62FB5@nutanix.com \
    --to=harshit@nutanix.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=gauri.patwardhan@nutanix.com \
    --cc=jon@nutanix.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=pauld@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rahul.chunduru@nutanix.com \
    --cc=rostedt@goodmis.org \
    --cc=stable@vger.kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=william.ton@nutanix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox