* Re: [GIT PULL] SCSI fixes for 4.9-rc3 [not found] <1478352591.2858.5.camel@HansenPartnership.com> @ 2016-11-11 3:30 ` Gabriel C 2016-11-11 4:10 ` Gabriel C 0 siblings, 1 reply; 4+ messages in thread From: Gabriel C @ 2016-11-11 3:30 UTC (permalink / raw) To: James Bottomley, Andrew Morton, Linus Torvalds Cc: linux-scsi, linux-kernel, stable On 05.11.2016 14:29, James Bottomley wrote: ... > Kashyap Desai (1): > scsi: megaraid_sas: Fix data integrity failure for JBOD (passthrough) devices > > diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c > index 9ff57de..d8b1fbd 100644 > --- a/drivers/scsi/megaraid/megaraid_sas_base.c > +++ b/drivers/scsi/megaraid/megaraid_sas_base.c > @@ -1700,16 +1700,13 @@ megasas_queue_command(struct Scsi_Host *shost, struct scsi_cmnd *scmd) > goto out_done; > } > > - switch (scmd->cmnd[0]) { > - case SYNCHRONIZE_CACHE: > - /* > - * FW takes care of flush cache on its own > - * No need to send it down > - */ > + /* > + * FW takes care of flush cache on its own for Virtual Disk. > + * No need to send it down for VD. For JBOD send SYNCHRONIZE_CACHE to FW. > + */ > + if ((scmd->cmnd[0] == SYNCHRONIZE_CACHE) && MEGASAS_IS_LOGICAL(scmd)) { > scmd->result = DID_OK << 16; > goto out_done; > - default: > - break; > } > > return instance->instancet->build_and_issue_cmd(instance, scmd); This patch breaks my box.. I'm not able to boot it anymore. It seems with this patch I have /dev/sda[a-z] to /dev/sdz[a-z] ?!? I'm not sure how to get an log since dracut times out and I'm dropped , after a very long time of probing 'ghost devices', in a emercency shell, journalctl doesn't work also.. After reverting this one I can boot normal. Box is a FUJITSU PRIMERGY TX200 S5.. This is from an working kernel.. [ 5.119371] megaraid_sas 0000:01:00.0: FW now in Ready state [ 5.119418] megaraid_sas 0000:01:00.0: firmware supports msix : (0) [ 5.119420] megaraid_sas 0000:01:00.0: current msix/online cpus : (1/16) [ 5.119422] megaraid_sas 0000:01:00.0: RDPQ mode : (disabled) [ 5.123100] ehci-pci 0000:00:1a.7: cache line size of 32 is not supported [ 5.123113] ehci-pci 0000:00:1a.7: irq 18, io mem 0xb0020000 ... [ 5.208063] megaraid_sas 0000:01:00.0: controller type : MR(256MB) [ 5.208065] megaraid_sas 0000:01:00.0: Online Controller Reset(OCR) : Enabled [ 5.208067] megaraid_sas 0000:01:00.0: Secure JBOD support : No [ 5.208070] megaraid_sas 0000:01:00.0: megasas_init_mfi: fw_support_ieee=0 [ 5.208073] megaraid_sas 0000:01:00.0: INIT adapter done [ 5.208075] megaraid_sas 0000:01:00.0: Jbod map is not supported megasas_setup_jbod_map 4967 [ 5.230163] megaraid_sas 0000:01:00.0: MR_DCMD_PD_LIST_QUERY failed/not supported by firmware [ 5.252080] megaraid_sas 0000:01:00.0: DCMD not supported by firmware - megasas_ld_list_query 4369 [ 5.274086] megaraid_sas 0000:01:00.0: pci id : (0x1000)/(0x0060)/(0x1734)/(0x10f9) [ 5.274089] megaraid_sas 0000:01:00.0: unevenspan support : no [ 5.274090] megaraid_sas 0000:01:00.0: firmware crash dump : no [ 5.274092] megaraid_sas 0000:01:00.0: jbod sync map : no [ 5.274094] scsi host0: Avago SAS based MegaRAID driver [ 5.280022] scsi 0:0:6:0: Direct-Access ATA WDC WD5002ABYS-5 3B06 PQ: 0 ANSI: 5 [ 5.282153] scsi 0:0:7:0: Direct-Access ATA WDC WD5002ABYS-5 3B06 PQ: 0 ANSI: 5 [ 5.285180] scsi 0:0:10:0: Direct-Access ATA ST500NM0011 FTM6 PQ: 0 ANSI: 5 [ 5.369885] scsi 0:2:0:0: Direct-Access LSI MegaRAID SAS RMB 1.40 PQ: 0 ANSI: 5 .. Please let me know if you need more infos and/or want me to test patches. Best Regards, Gabriel C ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PULL] SCSI fixes for 4.9-rc3 2016-11-11 3:30 ` [GIT PULL] SCSI fixes for 4.9-rc3 Gabriel C @ 2016-11-11 4:10 ` Gabriel C 2016-11-12 1:08 ` Kashyap Desai 0 siblings, 1 reply; 4+ messages in thread From: Gabriel C @ 2016-11-11 4:10 UTC (permalink / raw) To: James Bottomley, Andrew Morton, Linus Torvalds Cc: linux-scsi, linux-kernel, stable On 11.11.2016 04:30, Gabriel C wrote: > > On 05.11.2016 14:29, James Bottomley wrote: > > > ... > >> Kashyap Desai (1): >> scsi: megaraid_sas: Fix data integrity failure for JBOD (passthrough) devices >> >> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c >> index 9ff57de..d8b1fbd 100644 >> --- a/drivers/scsi/megaraid/megaraid_sas_base.c >> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c >> @@ -1700,16 +1700,13 @@ megasas_queue_command(struct Scsi_Host *shost, struct scsi_cmnd *scmd) >> goto out_done; >> } >> >> - switch (scmd->cmnd[0]) { >> - case SYNCHRONIZE_CACHE: >> - /* >> - * FW takes care of flush cache on its own >> - * No need to send it down >> - */ >> + /* >> + * FW takes care of flush cache on its own for Virtual Disk. >> + * No need to send it down for VD. For JBOD send SYNCHRONIZE_CACHE to FW. >> + */ >> + if ((scmd->cmnd[0] == SYNCHRONIZE_CACHE) && MEGASAS_IS_LOGICAL(scmd)) { >> scmd->result = DID_OK << 16; >> goto out_done; >> - default: >> - break; >> } >> >> return instance->instancet->build_and_issue_cmd(instance, scmd); > > This patch breaks my box.. I'm not able to boot it anymore. > It seems with this patch I have /dev/sda[a-z] to /dev/sdz[a-z] ?!? > > I'm not sure how to get an log since dracut times out and I'm dropped , after a very long time > of probing 'ghost devices', in a emercency shell, journalctl doesn't work also.. > > After reverting this one I can boot normal. > > Box is a FUJITSU PRIMERGY TX200 S5.. > > This is from an working kernel.. > > [ 5.119371] megaraid_sas 0000:01:00.0: FW now in Ready state > [ 5.119418] megaraid_sas 0000:01:00.0: firmware supports msix : (0) > [ 5.119420] megaraid_sas 0000:01:00.0: current msix/online cpus : (1/16) > [ 5.119422] megaraid_sas 0000:01:00.0: RDPQ mode : (disabled) > [ 5.123100] ehci-pci 0000:00:1a.7: cache line size of 32 is not supported > [ 5.123113] ehci-pci 0000:00:1a.7: irq 18, io mem 0xb0020000 > > ... > > [ 5.208063] megaraid_sas 0000:01:00.0: controller type : MR(256MB) > [ 5.208065] megaraid_sas 0000:01:00.0: Online Controller Reset(OCR) : Enabled > [ 5.208067] megaraid_sas 0000:01:00.0: Secure JBOD support : No > [ 5.208070] megaraid_sas 0000:01:00.0: megasas_init_mfi: fw_support_ieee=0 > [ 5.208073] megaraid_sas 0000:01:00.0: INIT adapter done > [ 5.208075] megaraid_sas 0000:01:00.0: Jbod map is not supported megasas_setup_jbod_map 4967 > [ 5.230163] megaraid_sas 0000:01:00.0: MR_DCMD_PD_LIST_QUERY failed/not supported by firmware > [ 5.252080] megaraid_sas 0000:01:00.0: DCMD not supported by firmware - megasas_ld_list_query 4369 > [ 5.274086] megaraid_sas 0000:01:00.0: pci id : (0x1000)/(0x0060)/(0x1734)/(0x10f9) > [ 5.274089] megaraid_sas 0000:01:00.0: unevenspan support : no > [ 5.274090] megaraid_sas 0000:01:00.0: firmware crash dump : no > [ 5.274092] megaraid_sas 0000:01:00.0: jbod sync map : no > [ 5.274094] scsi host0: Avago SAS based MegaRAID driver > [ 5.280022] scsi 0:0:6:0: Direct-Access ATA WDC WD5002ABYS-5 3B06 PQ: 0 ANSI: 5 > [ 5.282153] scsi 0:0:7:0: Direct-Access ATA WDC WD5002ABYS-5 3B06 PQ: 0 ANSI: 5 > [ 5.285180] scsi 0:0:10:0: Direct-Access ATA ST500NM0011 FTM6 PQ: 0 ANSI: 5 > [ 5.369885] scsi 0:2:0:0: Direct-Access LSI MegaRAID SAS RMB 1.40 PQ: 0 ANSI: 5 > > .. > > Please let me know if you need more infos and/or want me to test patches. > > I managed to get some parts of the broken dmesg. There it is : http://ftp.frugalware.org/pub/other/people/crazy/kernel/broken-dmesg ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [GIT PULL] SCSI fixes for 4.9-rc3 2016-11-11 4:10 ` Gabriel C @ 2016-11-12 1:08 ` Kashyap Desai 2016-11-12 2:05 ` Gabriel C 0 siblings, 1 reply; 4+ messages in thread From: Kashyap Desai @ 2016-11-12 1:08 UTC (permalink / raw) To: Gabriel C, James Bottomley, Andrew Morton, Linus Torvalds Cc: linux-scsi, linux-kernel, stable > -----Original Message----- > From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi- > owner@vger.kernel.org] On Behalf Of Gabriel C > Sent: Friday, November 11, 2016 9:40 AM > To: James Bottomley; Andrew Morton; Linus Torvalds > Cc: linux-scsi; linux-kernel; stable@vger.kernel.org > Subject: Re: [GIT PULL] SCSI fixes for 4.9-rc3 > > > > On 11.11.2016 04:30, Gabriel C wrote: > > > > On 05.11.2016 14:29, James Bottomley wrote: > > > > > > ... > > > >> Kashyap Desai (1): > >> scsi: megaraid_sas: Fix data integrity failure for JBOD > >> (passthrough) devices > >> > >> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c > >> b/drivers/scsi/megaraid/megaraid_sas_base.c > >> index 9ff57de..d8b1fbd 100644 > >> --- a/drivers/scsi/megaraid/megaraid_sas_base.c > >> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c > >> @@ -1700,16 +1700,13 @@ megasas_queue_command(struct Scsi_Host > *shost, struct scsi_cmnd *scmd) > >> goto out_done; > >> } > >> > >> - switch (scmd->cmnd[0]) { > >> - case SYNCHRONIZE_CACHE: > >> - /* > >> - * FW takes care of flush cache on its own > >> - * No need to send it down > >> - */ > >> + /* > >> + * FW takes care of flush cache on its own for Virtual Disk. > >> + * No need to send it down for VD. For JBOD send > SYNCHRONIZE_CACHE to FW. > >> + */ > >> + if ((scmd->cmnd[0] == SYNCHRONIZE_CACHE) && > >> +MEGASAS_IS_LOGICAL(scmd)) { > >> scmd->result = DID_OK << 16; > >> goto out_done; > >> - default: > >> - break; > >> } > >> > >> return instance->instancet->build_and_issue_cmd(instance, scmd); > > > > This patch breaks my box.. I'm not able to boot it anymore. > > It seems with this patch I have /dev/sda[a-z] to /dev/sdz[a-z] ?!? > > > > I'm not sure how to get an log since dracut times out and I'm dropped > > , after a very long time of probing 'ghost devices', in a emercency > > shell, > journalctl doesn't work also.. > > > > After reverting this one I can boot normal. > > > > Box is a FUJITSU PRIMERGY TX200 S5.. Please check now commit. Below commit has complete fix. http://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/commit/?id=5e5ec1759dd663a1d5a2f10930224dd009e500e8 > > > > This is from an working kernel.. > > > > [ 5.119371] megaraid_sas 0000:01:00.0: FW now in Ready state > > [ 5.119418] megaraid_sas 0000:01:00.0: firmware supports msix > > : (0) > > [ 5.119420] megaraid_sas 0000:01:00.0: current msix/online cpus > > : (1/16) > > [ 5.119422] megaraid_sas 0000:01:00.0: RDPQ mode : (disabled) > > [ 5.123100] ehci-pci 0000:00:1a.7: cache line size of 32 is not > > supported > > [ 5.123113] ehci-pci 0000:00:1a.7: irq 18, io mem 0xb0020000 > > > > ... > > > > [ 5.208063] megaraid_sas 0000:01:00.0: controller type : > > MR(256MB) > > [ 5.208065] megaraid_sas 0000:01:00.0: Online Controller Reset(OCR) > > : > Enabled > > [ 5.208067] megaraid_sas 0000:01:00.0: Secure JBOD support : No > > [ 5.208070] megaraid_sas 0000:01:00.0: megasas_init_mfi: > fw_support_ieee=0 > > [ 5.208073] megaraid_sas 0000:01:00.0: INIT adapter done > > [ 5.208075] megaraid_sas 0000:01:00.0: Jbod map is not supported > megasas_setup_jbod_map 4967 > > [ 5.230163] megaraid_sas 0000:01:00.0: MR_DCMD_PD_LIST_QUERY > failed/not supported by firmware > > [ 5.252080] megaraid_sas 0000:01:00.0: DCMD not supported by > > firmware - > megasas_ld_list_query 4369 > > [ 5.274086] megaraid_sas 0000:01:00.0: pci id : > (0x1000)/(0x0060)/(0x1734)/(0x10f9) > > [ 5.274089] megaraid_sas 0000:01:00.0: unevenspan support : no > > [ 5.274090] megaraid_sas 0000:01:00.0: firmware crash dump : no > > [ 5.274092] megaraid_sas 0000:01:00.0: jbod sync map : no > > [ 5.274094] scsi host0: Avago SAS based MegaRAID driver > > [ 5.280022] scsi 0:0:6:0: Direct-Access ATA WDC WD5002ABYS-5 > > 3B06 > PQ: 0 ANSI: 5 > > [ 5.282153] scsi 0:0:7:0: Direct-Access ATA WDC WD5002ABYS-5 > > 3B06 > PQ: 0 ANSI: 5 > > [ 5.285180] scsi 0:0:10:0: Direct-Access ATA ST500NM0011 > > FTM6 PQ: > 0 ANSI: 5 > > [ 5.369885] scsi 0:2:0:0: Direct-Access LSI MegaRAID SAS RMB > > 1.40 PQ: > 0 ANSI: 5 > > > > .. > > > > Please let me know if you need more infos and/or want me to test > > patches. > > > > > > I managed to get some parts of the broken dmesg. There it is : > > http://ftp.frugalware.org/pub/other/people/crazy/kernel/broken-dmesg > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of > a message to majordomo@vger.kernel.org More majordomo info at > http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PULL] SCSI fixes for 4.9-rc3 2016-11-12 1:08 ` Kashyap Desai @ 2016-11-12 2:05 ` Gabriel C 0 siblings, 0 replies; 4+ messages in thread From: Gabriel C @ 2016-11-12 2:05 UTC (permalink / raw) To: Kashyap Desai, James Bottomley, Andrew Morton, Linus Torvalds Cc: linux-scsi, linux-kernel, stable On 12.11.2016 02:08, Kashyap Desai wrote: >> -----Original Message----- >> From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi- >> owner@vger.kernel.org] On Behalf Of Gabriel C >> Sent: Friday, November 11, 2016 9:40 AM >> To: James Bottomley; Andrew Morton; Linus Torvalds >> Cc: linux-scsi; linux-kernel; stable@vger.kernel.org >> Subject: Re: [GIT PULL] SCSI fixes for 4.9-rc3 >> >> >> >> On 11.11.2016 04:30, Gabriel C wrote: >>> >>> On 05.11.2016 14:29, James Bottomley wrote: >>> >>> >>> ... >>> >>>> Kashyap Desai (1): >>>> scsi: megaraid_sas: Fix data integrity failure for JBOD >>>> (passthrough) devices >>>> >>>> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c >>>> b/drivers/scsi/megaraid/megaraid_sas_base.c >>>> index 9ff57de..d8b1fbd 100644 >>>> --- a/drivers/scsi/megaraid/megaraid_sas_base.c >>>> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c >>>> @@ -1700,16 +1700,13 @@ megasas_queue_command(struct Scsi_Host >> *shost, struct scsi_cmnd *scmd) >>>> goto out_done; >>>> } >>>> >>>> - switch (scmd->cmnd[0]) { >>>> - case SYNCHRONIZE_CACHE: >>>> - /* >>>> - * FW takes care of flush cache on its own >>>> - * No need to send it down >>>> - */ >>>> + /* >>>> + * FW takes care of flush cache on its own for Virtual Disk. >>>> + * No need to send it down for VD. For JBOD send >> SYNCHRONIZE_CACHE to FW. >>>> + */ >>>> + if ((scmd->cmnd[0] == SYNCHRONIZE_CACHE) && >>>> +MEGASAS_IS_LOGICAL(scmd)) { >>>> scmd->result = DID_OK << 16; >>>> goto out_done; >>>> - default: >>>> - break; >>>> } >>>> >>>> return instance->instancet->build_and_issue_cmd(instance, scmd); >>> >>> This patch breaks my box.. I'm not able to boot it anymore. >>> It seems with this patch I have /dev/sda[a-z] to /dev/sdz[a-z] ?!? >>> >>> I'm not sure how to get an log since dracut times out and I'm dropped >>> , after a very long time of probing 'ghost devices', in a emercency >>> shell, >> journalctl doesn't work also.. >>> >>> After reverting this one I can boot normal. >>> >>> Box is a FUJITSU PRIMERGY TX200 S5.. > > Please check now commit. Below commit has complete fix. > > http://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/commit/?id=5e5ec1759dd663a1d5a2f10930224dd009e500e8 > This patch fixes the problem for me. Thank you. Regards, Gabriel C ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-12 2:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1478352591.2858.5.camel@HansenPartnership.com>
2016-11-11 3:30 ` [GIT PULL] SCSI fixes for 4.9-rc3 Gabriel C
2016-11-11 4:10 ` Gabriel C
2016-11-12 1:08 ` Kashyap Desai
2016-11-12 2:05 ` Gabriel C
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).