From: "Murilo Opsfelder Araújo" <muriloo@linux.ibm.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
David Carrillo-Cisneros <davidcc@google.com>,
He Kuang <hekuang@huawei.com>, Ingo Molnar <mingo@redhat.com>,
Jiri Olsa <jolsa@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Paul Mackerras <paulus@samba.org>, Paul Turner <pjt@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Sasha Levin <alexander.levin@microsoft.com>,
Simon Que <sque@chromium.org>,
Stephane Eranian <eranian@google.com>,
Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH] perf session: Fix undeclared 'oe'
Date: Wed, 11 Apr 2018 17:21:29 -0300 [thread overview]
Message-ID: <82d8f577-bbbb-0419-bf41-057522eb3f30@linux.ibm.com> (raw)
In-Reply-To: <20180411193353.GA5656@kroah.com>
On 04/11/2018 04:33 PM, Greg Kroah-Hartman wrote:
> On Wed, Apr 11, 2018 at 03:41:35PM -0300, Murilo Opsfelder Araujo wrote:
>> Using linux-3.18.y branch, perf build fails with the following:
>>
>> $ make -s -j16 -C tools/perf V=1 WERROR=0 NO_LIBUNWIND=1 HAVE_CPLUS_DEMANGLE=1 NO_GTK2=1 NO_LIBNUMA=1 NO_STRLCPY=1 NO_BIONIC=1 prefix=/usr DESTDIR=/tmp/builddir/build all
>> [...]
>> util/session.c: In function ‘__perf_session__process_pipe_events’:
>> util/session.c:1093:36: error: ‘oe’ undeclared (first use in this function)
>> ordered_events__set_copy_on_queue(oe, true);
>> ^
>> util/session.c:1093:36: note: each undeclared identifier is reported only once for each function it appears in
>>
>> This patch fixes it for linux-3.18.y branch.
>
> Why is this failing now? Has it always been broken? Is there an
> upstream patch that fixed this instead?
>
Hi, Greg.
We've caught this build issue this week. I'm not sure since when it's
failing.
The upstream patch that fixes this is:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fa713a4eb9cebe5dec71b1bd11429603e17d841d
commit fa713a4eb9cebe5dec71b1bd11429603e17d841d
Author: Arnaldo Carvalho de Melo <acme@redhat.com>
Date: Tue Mar 3 11:48:12 2015 -0300
perf ordered_events: Untangle from perf_session
But it doesn't apply straightforwardly. At
fa713a4eb9cebe5dec71b1bd11429603e17d841d, perf API and perf_evlist
struct are slightly different from linux-3.18.y.
A list of upstream patches for a clean backport (I think) would be:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=54245fdc357613633954bfd38cffb71cb9def067
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=75be989a7a18e9666efd92b846ee48bed79e8086
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=313e53b08e99b1dacf9ea2b0fbe97890db1ea95f
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9fa8727aa4d98d35ca50ef9cd8a50c6468af921d
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fa713a4eb9cebe5dec71b1bd11429603e17d841d
Do you prefer all above patches backported to linux-3.18.y or just the
one-line fix I sent?
>> Fixes: 95b33b99cdd6 ("perf inject: Copy events when reordering events in pipe mode")
>
> Was this just a bad backport?
Some patches were left behind, I guess.
>
> thanks,
>
> greg k-h
>
Cheers
Murilo
next prev parent reply other threads:[~2018-04-11 20:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 18:41 [PATCH] perf session: Fix undeclared 'oe' Murilo Opsfelder Araujo
2018-04-11 19:33 ` Greg Kroah-Hartman
2018-04-11 20:21 ` Murilo Opsfelder Araújo [this message]
2018-04-30 17:11 ` Murilo Opsfelder Araujo
2018-04-30 17:20 ` Greg Kroah-Hartman
2018-04-30 17:49 ` Greg Kroah-Hartman
2018-04-30 18:41 ` Murilo Opsfelder Araujo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82d8f577-bbbb-0419-bf41-057522eb3f30@linux.ibm.com \
--to=muriloo@linux.ibm.com \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=alexander.levin@microsoft.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=davidcc@google.com \
--cc=eranian@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=sque@chromium.org \
--cc=stable@vger.kernel.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).