From: Patrice CHOTARD <patrice.chotard@foss.st.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: <devicetree@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: st: Add memory-region-names property for stm32mp257f-ev1
Date: Wed, 6 Aug 2025 14:36:55 +0200 [thread overview]
Message-ID: <832fb088-8862-4bd7-82a4-0e7ad58efe76@foss.st.com> (raw)
In-Reply-To: <9e0c5453-b8f4-4d0a-8e8d-82014aac67dd@kernel.org>
On 8/6/25 10:23, Krzysztof Kozlowski wrote:
> On 06/08/2025 10:09, Patrice Chotard wrote:
>> Add memory-region-names property for stm32mp257f-ev1.
>> This allows to identify and check memory-map area's configuration.
>
> No, first entry is already identified.
ok
>
>>
>> Cc: stable@vger.kernel.org
>> Fixes: cad2492de91c ("arm64: dts: st: Add SPI NOR flash support on stm32mp257f-ev1 board")
>>
>
> No blank lines.
ok
>
>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>> ---
>> arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts b/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts
>> index 2f561ad4066544445e93db78557bc4be1c27095a..16309029758cf24834f406f5203046ded371a8f9 100644
>> --- a/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts
>> +++ b/arch/arm64/boot/dts/st/stm32mp257f-ev1.dts
>> @@ -197,6 +197,7 @@ &i2c8 {
>>
>> &ommanager {
>> memory-region = <&mm_ospi1>;
>> + memory-region-names = "mm_ospi1";
>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
My bad, i am preparing the v2.
Thanks
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
> Maybe you need to update your dtschema and yamllint. Don't rely on
> distro packages for dtschema and be sure you are using the latest
> released dtschema.
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2025-08-06 12:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 8:09 [PATCH] arm64: dts: st: Add memory-region-names property for stm32mp257f-ev1 Patrice Chotard
2025-08-06 8:23 ` Krzysztof Kozlowski
2025-08-06 12:36 ` Patrice CHOTARD [this message]
2025-08-06 12:44 ` Krzysztof Kozlowski
2025-08-07 11:49 ` Patrice CHOTARD
2025-08-06 14:40 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=832fb088-8862-4bd7-82a4-0e7ad58efe76@foss.st.com \
--to=patrice.chotard@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox