From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CBEAC282C3 for ; Thu, 24 Jan 2019 17:55:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F38AC218A6 for ; Thu, 24 Jan 2019 17:55:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727991AbfAXRzd (ORCPT ); Thu, 24 Jan 2019 12:55:33 -0500 Received: from mga07.intel.com ([134.134.136.100]:61729 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727664AbfAXRzd (ORCPT ); Thu, 24 Jan 2019 12:55:33 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2019 09:55:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,517,1539673200"; d="scan'208";a="117172504" Received: from mdochtor-mobl2.ger.corp.intel.com ([10.252.12.195]) by fmsmga007.fm.intel.com with ESMTP; 24 Jan 2019 09:55:31 -0800 Message-ID: <83b55431ab3d8c5470b268f488413c78e81bb7bb.camel@intel.com> Subject: Re: [PATCH 4.19] iwlwifi: mvm: Send LQ command as async when necessary From: Luciano Coelho To: Greg KH Cc: Avraham Stern , Emmanuel Grumbach , stable@vger.kernel.org Date: Thu, 24 Jan 2019 19:55:30 +0200 In-Reply-To: <20190124175033.GA7484@kroah.com> References: <20190122115031.15770-1-emmanuel.grumbach@intel.com> <5a31d628cb46c48aca6d6a78241e9ea4e21db3b9.camel@intel.com> <20190124175033.GA7484@kroah.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, 2019-01-24 at 18:50 +0100, Greg KH wrote: > On Thu, Jan 24, 2019 at 10:47:12AM +0200, Luciano Coelho wrote: > > Hi Greg, > > > > This patch fixes a few bugs reported in bugzilla, about scheduling > > while atomic. There were at least 4 reports[1], so it seems to be > > a > > common occurrence. > > > > The patch looks large, but it's basically just a new boolean been > > passed around in order to decide whether we send a message > > synchronously or not. > > > > Is it possible to queue it for 4.19.y? > > > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=200991 > > https://bugzilla.kernel.org/show_bug.cgi?id=202219 > > https://bugzilla.kernel.org/show_bug.cgi?id=201297 > > https://bugzilla.kernel.org/show_bug.cgi?id=201355 > > Now queued up, thanks. Thanks, Greg! > Note, apis that add "booleans" to them are horrid, good luck > maintaining that mess :( Yeah, you're right. This patch demonstrates that, the boolean needs to be passed from and to everywhere. We should probably just split that function in two. Thanks for the comment. -- Cheers, Luca.