public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: "Stanley Chang[昌育德]" <stanley_chang@realtek.com>
To: Stefan Eichenberger <eichest@gmail.com>,
	Johan Hovold <johan+linaro@kernel.org>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	Maxime Ripard <mripard@kernel.org>
Subject: RE: [PATCH] USB: xhci-plat: fix legacy PHY double inity
Date: Mon, 6 Nov 2023 03:48:37 +0000	[thread overview]
Message-ID: <848aad6777f54fa88ebd4277642853aa@realtek.com> (raw)
In-Reply-To: <ZUY8cGrofUtPOMV8@eichest-laptop>


> On Fri, Nov 03, 2023 at 05:43:23PM +0100, Johan Hovold wrote:
> > Commits 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support") and
> > 9134c1fd0503 ("usb: xhci: plat: Add USB 3.0 phy support") added
> > support for looking up legacy PHYs from the sysdev devicetree node and
> > initialising them.
> >
> > This broke drivers such as dwc3 which manages PHYs themself as the
> > PHYs would now be initialised twice, something which specifically can
> > lead to resources being left enabled during suspend (e.g. with the
> > usb_phy_generic PHY driver).
> >
> > As the dwc3 driver uses driver-name matching for the xhci platform
> > device, fix this by only looking up and initialising PHYs for devices
> > that have been matched using OF.
> >
> > Note that checking that the platform device has a devicetree node
> > would currently be sufficient, but that could lead to subtle breakages
> > in case anyone ever tries to reuse an ancestor's node.
> >
> > Fixes: 7b8ef22ea547 ("usb: xhci: plat: Add USB phy support")
> > Fixes: 9134c1fd0503 ("usb: xhci: plat: Add USB 3.0 phy support")
> > Cc: stable@vger.kernel.org      # 4.1
> > Cc: Maxime Ripard <mripard@kernel.org>
> > Cc: Stanley Chang <stanley_chang@realtek.com>
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> 
> Tested-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>

Tested-by: Stanley Chang <stanley_chang@realtek.com>



  reply	other threads:[~2023-11-06  3:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-03 16:43 [PATCH] USB: xhci-plat: fix legacy PHY double init Johan Hovold
2023-11-04 12:43 ` [PATCH] USB: xhci-plat: fix legacy PHY double inity Stefan Eichenberger
2023-11-06  3:48   ` Stanley Chang[昌育德] [this message]
2023-11-06  6:53   ` Stanley Chang[昌育德]
2023-11-06  9:53     ` Johan Hovold
2023-11-06 10:08       ` Stanley Chang[昌育德]
2023-11-06 10:18         ` Johan Hovold
2023-11-06 10:37           ` Stanley Chang[昌育德]
2023-11-06 10:42             ` Johan Hovold
2023-11-07  1:16               ` Stanley Chang[昌育德]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=848aad6777f54fa88ebd4277642853aa@realtek.com \
    --to=stanley_chang@realtek.com \
    --cc=eichest@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan+linaro@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=mripard@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox