* Re: stable-rc build: 3 warnings 3 failures (stable-rc/v4.4.68-29-geca6664)
[not found] <591b970f.9985620a.cf175.1a5d@mx.google.com>
@ 2017-05-17 8:37 ` Arnd Bergmann
2017-05-17 8:57 ` Christoffer Dall
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2017-05-17 8:37 UTC (permalink / raw)
To: Olof's autobuilder
Cc: Olof Johansson, Kernel Build Reports Mailman List,
Christoffer Dall, Marc Zyngier, stable, gregkh, Suzuki K Poulose,
Andre Przywara, Will Deacon
On Wed, May 17, 2017 at 2:19 AM, Olof's autobuilder <build@lixom.net> wrote:
> -------------------------------------------------------------------------------
>
> Failed defconfigs:
> arm64.allmodconfig
> arm64.defconfig
> arm64.nosmp_defconfig
>
> -------------------------------------------------------------------------------
>
> Errors:
>
> arm64.allmodconfig:
> /work/build/batch/arch/arm64/include/asm/kvm_emulate.h:223:16: error: 'ESR_ELx_SYS64_ISS_RT_MASK' undeclared (first use in this function)
> /work/build/batch/arch/arm64/include/asm/kvm_emulate.h:223:46: error: 'ESR_ELx_SYS64_ISS_RT_SHIFT' undeclared (first use in this function)
> /work/build/batch/arch/arm64/include/asm/kvm_emulate.h:223:16: error: 'ESR_ELx_SYS64_ISS_RT_MASK' undeclared (first use in this function)
This is evidently caused by the backport of
c667186f1c01 ("arm64: KVM: Fix decoding of Rt/Rt2 when trapping
AArch32 CP accesses")
The missing constants were added in linux-4.9 by
9dbd5bb25c56 ("arm64: Refactor sysinstr exception handling")
I don't think that commit is something we want backported as well
as it is part of a longer series, but we could simply add the two
lines to arch/arm64/include/asm/esr.h:
+#define ESR_ELx_SYS64_ISS_RT_SHIFT 5
+#define ESR_ELx_SYS64_ISS_RT_MASK (UL(0x1f) << ESR_ELx_SYS64_ISS_RT_SHIFT)
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: stable-rc build: 3 warnings 3 failures (stable-rc/v4.4.68-29-geca6664)
2017-05-17 8:37 ` stable-rc build: 3 warnings 3 failures (stable-rc/v4.4.68-29-geca6664) Arnd Bergmann
@ 2017-05-17 8:57 ` Christoffer Dall
2017-05-18 7:08 ` Marc Zyngier
0 siblings, 1 reply; 3+ messages in thread
From: Christoffer Dall @ 2017-05-17 8:57 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Olof's autobuilder, Olof Johansson,
Kernel Build Reports Mailman List, Marc Zyngier, Stable, gregkh,
Suzuki K Poulose, Andre Przywara, Will Deacon
On Wed, May 17, 2017 at 10:37 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Wed, May 17, 2017 at 2:19 AM, Olof's autobuilder <build@lixom.net> wrote:
>> -------------------------------------------------------------------------------
>>
>> Failed defconfigs:
>> arm64.allmodconfig
>> arm64.defconfig
>> arm64.nosmp_defconfig
>>
>> -------------------------------------------------------------------------------
>>
>> Errors:
>>
>> arm64.allmodconfig:
>> /work/build/batch/arch/arm64/include/asm/kvm_emulate.h:223:16: error: 'ESR_ELx_SYS64_ISS_RT_MASK' undeclared (first use in this function)
>> /work/build/batch/arch/arm64/include/asm/kvm_emulate.h:223:46: error: 'ESR_ELx_SYS64_ISS_RT_SHIFT' undeclared (first use in this function)
>> /work/build/batch/arch/arm64/include/asm/kvm_emulate.h:223:16: error: 'ESR_ELx_SYS64_ISS_RT_MASK' undeclared (first use in this function)
>
> This is evidently caused by the backport of
> c667186f1c01 ("arm64: KVM: Fix decoding of Rt/Rt2 when trapping
> AArch32 CP accesses")
>
> The missing constants were added in linux-4.9 by
> 9dbd5bb25c56 ("arm64: Refactor sysinstr exception handling")
>
> I don't think that commit is something we want backported as well
> as it is part of a longer series, but we could simply add the two
> lines to arch/arm64/include/asm/esr.h:
>
> +#define ESR_ELx_SYS64_ISS_RT_SHIFT 5
> +#define ESR_ELx_SYS64_ISS_RT_MASK (UL(0x1f) << ESR_ELx_SYS64_ISS_RT_SHIFT)
>
That seems like a good fix, but Marc has asked to have this patch
dropped from v4.4 stable for now and will provide a backport later.
Thanks,
-Christoffer
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: stable-rc build: 3 warnings 3 failures (stable-rc/v4.4.68-29-geca6664)
2017-05-17 8:57 ` Christoffer Dall
@ 2017-05-18 7:08 ` Marc Zyngier
0 siblings, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2017-05-18 7:08 UTC (permalink / raw)
To: Christoffer Dall
Cc: Arnd Bergmann, Olof's autobuilder, Olof Johansson,
Kernel Build Reports Mailman List, Stable, gregkh,
Suzuki K Poulose, Andre Przywara, Will Deacon
On Wed, May 17 2017 at 09:57:15 AM, Christoffer Dall <cdall@linaro.org> wrote:
> On Wed, May 17, 2017 at 10:37 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> On Wed, May 17, 2017 at 2:19 AM, Olof's autobuilder <build@lixom.net> wrote:
>>> -------------------------------------------------------------------------------
>>>
>>> Failed defconfigs:
>>> arm64.allmodconfig
>>> arm64.defconfig
>>> arm64.nosmp_defconfig
>>>
>>> -------------------------------------------------------------------------------
>>>
>>> Errors:
>>>
>>> arm64.allmodconfig:
>>> /work/build/batch/arch/arm64/include/asm/kvm_emulate.h:223:16:
>>> error: 'ESR_ELx_SYS64_ISS_RT_MASK' undeclared (first use in this
>>> function)
>>> /work/build/batch/arch/arm64/include/asm/kvm_emulate.h:223:46:
>>> error: 'ESR_ELx_SYS64_ISS_RT_SHIFT' undeclared (first use in this
>>> function)
>>> /work/build/batch/arch/arm64/include/asm/kvm_emulate.h:223:16:
>>> error: 'ESR_ELx_SYS64_ISS_RT_MASK' undeclared (first use in this
>>> function)
>>
>> This is evidently caused by the backport of
>> c667186f1c01 ("arm64: KVM: Fix decoding of Rt/Rt2 when trapping
>> AArch32 CP accesses")
>>
>> The missing constants were added in linux-4.9 by
>> 9dbd5bb25c56 ("arm64: Refactor sysinstr exception handling")
>>
>> I don't think that commit is something we want backported as well
>> as it is part of a longer series, but we could simply add the two
>> lines to arch/arm64/include/asm/esr.h:
>>
>> +#define ESR_ELx_SYS64_ISS_RT_SHIFT 5
>> +#define ESR_ELx_SYS64_ISS_RT_MASK (UL(0x1f) <<
>> ESR_ELx_SYS64_ISS_RT_SHIFT)
>>
>
> That seems like a good fix, but Marc has asked to have this patch
> dropped from v4.4 stable for now and will provide a backport later.
Sorry, I missed this earlier. I've just sent Greg an updated patch.
Thanks,
M.
--
Jazz is not dead. It just smells funny.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-18 7:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <591b970f.9985620a.cf175.1a5d@mx.google.com>
2017-05-17 8:37 ` stable-rc build: 3 warnings 3 failures (stable-rc/v4.4.68-29-geca6664) Arnd Bergmann
2017-05-17 8:57 ` Christoffer Dall
2017-05-18 7:08 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).