From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7F7CC433FE for ; Tue, 1 Nov 2022 19:36:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229875AbiKATgF (ORCPT ); Tue, 1 Nov 2022 15:36:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229601AbiKATgE (ORCPT ); Tue, 1 Nov 2022 15:36:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9A191DF1D for ; Tue, 1 Nov 2022 12:36:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 48FE461725 for ; Tue, 1 Nov 2022 19:36:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACB04C433C1; Tue, 1 Nov 2022 19:36:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667331362; bh=Rj1bZFx9VnHU9uH341ke8qqC18aDyq7kOdah2pSpsFs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YC+I6FFOmLs2GrP43E1PIwZwp4hqH8c0hrhF5jnspJhqhuQ5qU/08rSdDT+hDr/oj GLlD9ZEkPSBSjm0M4Z9s2YzfvouqAt1N72Y0NnLcHdRRQGk4Eg5g1T1orcrfauiYzW E60pRxkPZaOKkjSU53zXQLEQbTt6zfAfXKymo2lJ8rE2CNPnskBMwvzKrTARa+gpxo ZrTzGoQ/wn1TIhe5d1pfJUbMyntHjOChT9jmIcBww1a8FkkTbuQYPiilRdGeVvTVby W2BPmfIXPmion7ug6/seJp1+ySq1Xr13teryrohXFmiBmX/tEGjdHOKRecOI8xPA6w Dg+PzXMPBqdpQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1opx3I-0033ep-8R; Tue, 01 Nov 2022 19:36:00 +0000 Date: Tue, 01 Nov 2022 19:35:59 +0000 Message-ID: <86a65aeacg.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: Catalin Marinas , Will Deacon , Peter Maydell , Richard Henderson , Vincent Donnefort , James Morse , Alexandru Elisei , Suzuki K Poulose , Oliver Upton , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, stable@vger.kernel.org Subject: Re: [PATCH v2 2/2] KVM: arm64: Trap access to SMPRI_EL1 and TPIDR2 in VHE mode In-Reply-To: References: <20221101112716.52035-1-broonie@kernel.org> <20221101112716.52035-3-broonie@kernel.org> <86bkpqer4z.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: broonie@kernel.org, catalin.marinas@arm.com, will@kernel.org, peter.maydell@linaro.org, richard.henderson@linaro.org, vdonnefort@google.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, 01 Nov 2022 14:30:09 +0000, Mark Brown wrote: > > On Tue, Nov 01, 2022 at 01:33:16PM +0000, Marc Zyngier wrote: > > Date: Tue, 1 Nov 2022 12:19:51 +0000 > > Subject: [PATCH] KVM: arm64: Fix SMPRI_EL1/TPIDR2_EL0 trapping on VHE > > > > The trapping of SMPRI_EL1 and TPIDR2_EL0 currently only really > > work on nVHE, as only this mode uses the fine-grained trapping > > that controls these two registers. > > > > Move the trapping enable/disable code into > > __{de,}activate_traps_common(), allowing it to be called when it > > actually matters on VHE, and remove the flipping of EL2 control > > for TPIDR2_EL0, which only affects the host access of this > > register. > > > > Fixes: 861262ab8627 ("KVM: arm64: Handle SME host state when running guests") > > Signed-off-by: Marc Zyngier > > Cc: stable@vger.kernel.org > > Reported-by: Mark Brown > Reviewed-by: Mark Brown Thanks. I've now applied the first patch and this one to kvmarm/fixes. M. -- Without deviation from the norm, progress is not possible.