From: Hans de Goede <hansg@kernel.org>
To: Mehdi Djait <mehdi.djait@linux.intel.com>
Cc: Bingbu Cao <bingbu.cao@intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 06/25] media: i2c: ov01a10: Fix test-pattern disabling
Date: Tue, 28 Oct 2025 15:38:28 +0100 [thread overview]
Message-ID: <8718bd8e-12b0-4c4e-9155-7e394f0d5a16@kernel.org> (raw)
In-Reply-To: <rywqbh2ku7aexskohujwsiv7yzgn7lipgdqol3rqtkcvqrmn3q@c6oe7wc45hti>
Hi Mehdi,
Thank you for all the reviews and testing.
On 28-Oct-25 1:08 PM, Mehdi Djait wrote:
> Hi Hans,
>
> Thank you for the patches!
>
> On Tue, Oct 14, 2025 at 07:40:14PM +0200, Hans de Goede wrote:
>> When the test-pattern control gets set to 0 (Disabled) 0 should be written
>> to the test-pattern register, rather then doing nothing.
>>
>
> A small question: Do you see any difference between test_pattern 1 and
> test_pattern 2 or I did not look hard enough at the screen ?
IIRC the one has the colors fading (a bit) from left to right and
the other from top to bottom ?
Regards,
Hans
next prev parent reply other threads:[~2025-10-28 14:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251014174033.20534-1-hansg@kernel.org>
2025-10-14 17:40 ` [PATCH 01/25] media: i2c: ov01a10: Fix the horizontal flip control Hans de Goede
2025-10-27 19:00 ` Mehdi Djait
2025-10-14 17:40 ` [PATCH 02/25] media: i2c: ov01a10: Fix reported pixel-rate value Hans de Goede
2025-10-27 19:03 ` Mehdi Djait
2025-10-14 17:40 ` [PATCH 03/25] media: i2c: ov01a10: Fix gain range Hans de Goede
2025-10-27 19:14 ` Mehdi Djait
2025-10-14 17:40 ` [PATCH 04/25] media: i2c: ov01a10: Add missing v4l2_subdev_cleanup() calls Hans de Goede
2025-10-15 2:37 ` Bingbu Cao
2025-10-15 2:46 ` Bingbu Cao
2025-10-28 11:24 ` Mehdi Djait
2025-10-14 17:40 ` [PATCH 05/25] media: i2c: ov01a10: Fix passing stream instead of pad to v4l2_subdev_state_get_format() Hans de Goede
2025-10-28 11:40 ` Mehdi Djait
2025-10-14 17:40 ` [PATCH 06/25] media: i2c: ov01a10: Fix test-pattern disabling Hans de Goede
2025-10-15 2:34 ` Bingbu Cao
2025-10-28 12:08 ` Mehdi Djait
2025-10-28 14:38 ` Hans de Goede [this message]
2025-10-28 15:38 ` Mehdi Djait
2025-10-28 15:52 ` Hans de Goede
2025-10-29 17:44 ` Mehdi Djait
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8718bd8e-12b0-4c4e-9155-7e394f0d5a16@kernel.org \
--to=hansg@kernel.org \
--cc=bingbu.cao@intel.com \
--cc=linux-media@vger.kernel.org \
--cc=mehdi.djait@linux.intel.com \
--cc=sakari.ailus@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox