From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D3F335CBC6; Tue, 27 Jan 2026 16:19:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769530752; cv=none; b=u0nhRXDWaRT6L6ijiefBw8zn64FnhWYczzUEK+fxBs53zHfdAEwn2EXTirhudcQSyckZ3ZfO4v/KYKWZelHY7vtgn0GQKLOfrdRgVkG93cxFM+Ka3skPFMfuFPQ/kbVak7n5frlvouT70NUbL/56lUVrMzv60E8FVAq5GB9IyDs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769530752; c=relaxed/simple; bh=Y1R+TJNguLWi69GtS7mRj+xsWoAN4CJgoKP+3u0CB4Y=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=uBnnI8i1lR0kM7E/JcVJHkgNPL6ldmhHxmqDxu+9gnxb042GbllNb3jhO0D8ZOYlcGOj7YK+xraSGD2WKMTBpX8twdw5fW3FEVAmV5kjyTcp8PO5knRp3EmNl1s9sT2oEzCr53AlK/CB2R64rzOYcTXqX23FpBgnrW2KkKzpLtg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=ufdKbr4O; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=abXFZ/MN; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="ufdKbr4O"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="abXFZ/MN" From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1769530749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5rTWFCtf+mdQvk1B3TlRGJzO6FYqSCXfxkBPbyjRRz0=; b=ufdKbr4Oqx/uYlPl3IAPk0gx8FgxGgkBFVhOgua7A07i2Cnam5feqLGvLEEGFKL/GO7Y+k 2TmQ2TG8ndfoSl2SudkSQuvJi6OOqcFqkpoQ2MKaQsmK/hR3KSY5zyP9bU1BWrQTP/oGS1 810cwHj+ehIG2WYYWcsqq44bsI/oLI43mHZ+6nnYjWI3XlKF+jwQoYyYyYLad1xrmqzsq3 ALlpTRJQGhyt6rEen6aOT9QqRKJdyQFOY+IQnzGMTS04GQ0AMtKQpzmM3/iViv2qhl7iT2 Ynw+4c2dpmWj+iC+XXTHd0Oln3iiPbVOueSqOF8ieshjPnveiDAr7RXdl7B7AA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1769530749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5rTWFCtf+mdQvk1B3TlRGJzO6FYqSCXfxkBPbyjRRz0=; b=abXFZ/MNcUARd7jEp9+PwBfc2hc3SIU3Xezk1TDbGygK45me6LMH7BdLw8fpraAVFrd7o8 Oa2hT11/vC1kSTAw== To: Andy Shevchenko , Ilpo =?utf-8?Q?J?= =?utf-8?Q?=C3=A4rvinen?= , Petr Mladek Cc: Greg Kroah-Hartman , Jiri Slaby , linux-serial , qianfan Zhao , Adriana Nicolae , Markus Mayer , Tim Kryger , Matt Porter , Heikki Krogerus , Jamie Iles , LKML , stable@vger.kernel.org, "Bandal, Shankar" , "Murthy, Shanth" Subject: Re: [PATCH 6/6] serial: 8250_dw: Ensure BUSY is deasserted In-Reply-To: References: <20260123172739.13410-1-ilpo.jarvinen@linux.intel.com> <20260123172739.13410-7-ilpo.jarvinen@linux.intel.com> Date: Tue, 27 Jan 2026 17:25:08 +0106 Message-ID: <871pjb6nb7.fsf@jogness.linutronix.de> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On 2026-01-27, Andy Shevchenko wrote: >> > > + if (d->in_idle) { >> > >> > > + /* >> > > + * FIXME: this deadlocks if port->lock is already held >> > > + * dev_err(p->dev, "Couldn't set LCR to %d\n", value); >> > > + */ >> > >> > Hmm... That FIXME should gone since we have non-blocking consoles, no? >> >> No, lockdep still gets angry if printing is used while holding port's >> lock. > > Hmm... Let's ask PRINTK people about this. John, do we still have a gap > with nbcon? Or did I misunderstand the scope of its use? The 8250 has not yet been converted to a nbcon. I am still working on it. Unfortunately I got side-tracked first fixing the broken 8250 console hardware-flow-control support. :-/ So the comment is correct. Once the driver converts to nbcon, the dev_err() is fine. Note that if the message is important, you could use a printk_deferred() here with a FIXME to say to convert it to dev_err() once the 8250 supports nbcon. John Ogness