* [PATCH] drm/i915/mst: update max stream count to match number of pipes
@ 2025-02-26 13:56 Jani Nikula
2025-02-26 15:40 ` Ville Syrjälä
0 siblings, 1 reply; 3+ messages in thread
From: Jani Nikula @ 2025-02-26 13:56 UTC (permalink / raw)
To: intel-gfx, intel-xe; +Cc: jani.nikula, stable, Imre Deak, Ville Syrjala
We create the stream encoders and attach connectors for each pipe we
have. As the number of pipes has increased, we've failed to update the
topology manager maximum number of payloads to match that. Bump up the
max stream count to match number of pipes, enabling the fourth stream on
platforms that support four pipes.
Cc: stable@vger.kernel.org
Cc: Imre Deak <imre.deak@intel.com>
Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp_mst.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
index 167e4a70ab12..822218d8cfd4 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
@@ -1896,7 +1896,8 @@ intel_dp_mst_encoder_init(struct intel_digital_port *dig_port, int conn_base_id)
/* create encoders */
mst_stream_encoders_create(dig_port);
ret = drm_dp_mst_topology_mgr_init(&intel_dp->mst_mgr, display->drm,
- &intel_dp->aux, 16, 3, conn_base_id);
+ &intel_dp->aux, 16,
+ INTEL_NUM_PIPES(display), conn_base_id);
if (ret) {
intel_dp->mst_mgr.cbs = NULL;
return ret;
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/i915/mst: update max stream count to match number of pipes
2025-02-26 13:56 [PATCH] drm/i915/mst: update max stream count to match number of pipes Jani Nikula
@ 2025-02-26 15:40 ` Ville Syrjälä
2025-02-27 10:18 ` Jani Nikula
0 siblings, 1 reply; 3+ messages in thread
From: Ville Syrjälä @ 2025-02-26 15:40 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, intel-xe, stable, Imre Deak
On Wed, Feb 26, 2025 at 03:56:26PM +0200, Jani Nikula wrote:
> We create the stream encoders and attach connectors for each pipe we
> have. As the number of pipes has increased, we've failed to update the
> topology manager maximum number of payloads to match that. Bump up the
> max stream count to match number of pipes, enabling the fourth stream on
> platforms that support four pipes.
>
> Cc: stable@vger.kernel.org
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp_mst.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> index 167e4a70ab12..822218d8cfd4 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> @@ -1896,7 +1896,8 @@ intel_dp_mst_encoder_init(struct intel_digital_port *dig_port, int conn_base_id)
> /* create encoders */
> mst_stream_encoders_create(dig_port);
> ret = drm_dp_mst_topology_mgr_init(&intel_dp->mst_mgr, display->drm,
> - &intel_dp->aux, 16, 3, conn_base_id);
> + &intel_dp->aux, 16,
> + INTEL_NUM_PIPES(display), conn_base_id);
> if (ret) {
> intel_dp->mst_mgr.cbs = NULL;
> return ret;
> --
> 2.39.5
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/i915/mst: update max stream count to match number of pipes
2025-02-26 15:40 ` Ville Syrjälä
@ 2025-02-27 10:18 ` Jani Nikula
0 siblings, 0 replies; 3+ messages in thread
From: Jani Nikula @ 2025-02-27 10:18 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx, intel-xe, stable, Imre Deak
On Wed, 26 Feb 2025, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Feb 26, 2025 at 03:56:26PM +0200, Jani Nikula wrote:
>> We create the stream encoders and attach connectors for each pipe we
>> have. As the number of pipes has increased, we've failed to update the
>> topology manager maximum number of payloads to match that. Bump up the
>> max stream count to match number of pipes, enabling the fourth stream on
>> platforms that support four pipes.
>>
>> Cc: stable@vger.kernel.org
>> Cc: Imre Deak <imre.deak@intel.com>
>> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Thanks, pushed to din.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/display/intel_dp_mst.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
>> index 167e4a70ab12..822218d8cfd4 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
>> @@ -1896,7 +1896,8 @@ intel_dp_mst_encoder_init(struct intel_digital_port *dig_port, int conn_base_id)
>> /* create encoders */
>> mst_stream_encoders_create(dig_port);
>> ret = drm_dp_mst_topology_mgr_init(&intel_dp->mst_mgr, display->drm,
>> - &intel_dp->aux, 16, 3, conn_base_id);
>> + &intel_dp->aux, 16,
>> + INTEL_NUM_PIPES(display), conn_base_id);
>> if (ret) {
>> intel_dp->mst_mgr.cbs = NULL;
>> return ret;
>> --
>> 2.39.5
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-27 10:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-26 13:56 [PATCH] drm/i915/mst: update max stream count to match number of pipes Jani Nikula
2025-02-26 15:40 ` Ville Syrjälä
2025-02-27 10:18 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox