Re: [PATCH] soc: qcom: pd-mapper: defer probing on sdm845

[Frank Oltmanns <frank@oltmanns.dev>]

Hi Krzysztof,

On 2025-02-12 at 06:45:17 +0100, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 05/02/2025 22:57, Frank Oltmanns wrote:
>> +static const struct of_device_id qcom_pdm_defer[] __maybe_unused = {
>> +	{ .compatible = "qcom,sdm845", .data = &first_dev_remoteproc3, },
>> +	{},
>> +};
>>  static void qcom_pdm_stop(struct qcom_pdm_data *data)
>>  {
>>  	qcom_pdm_free_domains(data);
>> @@ -637,6 +651,25 @@ static struct qcom_pdm_data *qcom_pdm_start(void)
>>  	return ERR_PTR(ret);
>>  }
>>
>> +static bool qcom_pdm_ready(struct auxiliary_device *auxdev)
>> +{
>> +	const struct of_device_id *match;
>> +	struct device_node *root;
>> +	struct qcom_pdm_probe_first_dev_quirk *first_dev;
>> +
>> +	root = of_find_node_by_path("/");
>> +	if (!root)
>> +		return true;
>> +
>> +	match = of_match_node(qcom_pdm_defer, root);
>
> Aren't you open-coding machine is compatible?
>

Thanks for pointing out of_machine_is_compatible — I wasn't aware of it!

The patch was already NACK'ed by Bjorn, but I still learned something
from your feedback.

Thanks,
  Frank

>
>
>
> Best regards,
> Krzysztof