From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBC09C4338F for ; Fri, 13 Aug 2021 07:47:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C78E16109D for ; Fri, 13 Aug 2021 07:47:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238974AbhHMHrb (ORCPT ); Fri, 13 Aug 2021 03:47:31 -0400 Received: from mga11.intel.com ([192.55.52.93]:57429 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239523AbhHMHrQ (ORCPT ); Fri, 13 Aug 2021 03:47:16 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10074"; a="212407152" X-IronPort-AV: E=Sophos;i="5.84,318,1620716400"; d="scan'208";a="212407152" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2021 00:46:50 -0700 X-IronPort-AV: E=Sophos;i="5.84,318,1620716400"; d="scan'208";a="517943170" Received: from cgearing-mobl.ger.corp.intel.com (HELO localhost) ([10.251.209.226]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2021 00:46:45 -0700 From: Jani Nikula To: Swati Sharma , intel-gfx@lists.freedesktop.org Cc: Swati Sharma , Ankit Nautiyal , Uma Shankar , Ville Syrj_l_ , Imre Deak , Manasi Navare , Jos_ Roberto de Souza , Sean Paul , stable@vger.kernel.org Subject: Re: [PATCH] drm/i915/display: Drop redundant debug print In-Reply-To: <20210812125845.27787-1-swati2.sharma@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210812125845.27787-1-swati2.sharma@intel.com> Date: Fri, 13 Aug 2021 10:46:42 +0300 Message-ID: <871r6xn5wd.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, 12 Aug 2021, Swati Sharma wrote: > drm_dp_dpcd_read/write already has debug error message. > Drop redundant error messages which gives false > status even if correct value is read in drm_dp_dpcd_read(). I guess the only problem is it gets harder to associate the preceding low level error messages with intel_dp_check_link_service_irq(). *shrug* Reviewed-by: Jani Nikula > > Fixes: 9488a030ac91 ("drm/i915: Add support for enabling link status and recovery") > Cc: Swati Sharma > Cc: Ankit Nautiyal > Cc: Uma Shankar (v2) > Cc: Jani Nikula > Cc: "Ville Syrj_l_" > Cc: Imre Deak > Cc: Manasi Navare > Cc: Uma Shankar > Cc: "Jos_ Roberto de Souza" > Cc: Sean Paul > Cc: # v5.12+ > > Link: https://patchwork.freedesktop.org/patch/msgid/20201218103723.30844-12-ankit.k.nautiyal@intel.com > Signed-off-by: Swati Sharma > --- > drivers/gpu/drm/i915/display/intel_dp.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index c386ef8eb200..5c84f51ad41d 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -3871,16 +3871,12 @@ static void intel_dp_check_link_service_irq(struct intel_dp *intel_dp) > return; > > if (drm_dp_dpcd_readb(&intel_dp->aux, > - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) { > - drm_dbg_kms(&i915->drm, "Error in reading link service irq vector\n"); > + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) > return; > - } > > if (drm_dp_dpcd_writeb(&intel_dp->aux, > - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) { > - drm_dbg_kms(&i915->drm, "Error in writing link service irq vector\n"); > + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) > return; > - } > > if (val & HDMI_LINK_STATUS_CHANGED) > intel_dp_handle_hdmi_link_status_change(intel_dp); -- Jani Nikula, Intel Open Source Graphics Center