From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com ([192.55.52.120]:8671 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751172AbcDUKVV (ORCPT ); Thu, 21 Apr 2016 06:21:21 -0400 From: Felipe Balbi To: Yoshihiro Shimoda , "mathias.nyman\@intel.com" , "gregkh\@linuxfoundation.org" Cc: "linux-usb\@vger.kernel.org" , "linux-renesas-soc\@vger.kernel.org" , "stable\@vger.kernel.org" Subject: RE: [PATCH] usb: host: xhci-rcar: Avoid long wait in xhci_reset() In-Reply-To: References: <1461232154-7420-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <874mavb7lk.fsf@intel.com> Date: Thu, 21 Apr 2016 13:19:18 +0300 Message-ID: <871t5zb6xl.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: stable-owner@vger.kernel.org List-ID: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Yoshihiro Shimoda writes: > Hi Felipe, > >> From: Felipe Balbi >> Sent: Thursday, April 21, 2016 7:05 PM >>=20 >> Yoshihiro Shimoda writes: >>=20 >> > If kernel configuration is CONFIG_USB_XHCI_PLATFORM=3Dy and >> > CONFIG_USB_XHCI_RCAR is not set, R-Car Gen2/3 will cause long wait >> > in xhci_reset() because such SoCs need specific initialization. >>=20 >> where is the delay coming from exactly ? > > The delay is coming from the following code: > > ret =3D xhci_handshake(&xhci->op_regs->command, > CMD_RESET, 0, 10 * 1000 * 1000); > if (ret) > return ret; okay, and why does reset fail ? > And, kernel log is the following: > > [ 1.565605] xhci-hcd ee000000.usb: xHCI Host Controller > [ 1.570636] xhci-hcd ee000000.usb: new USB bus registered, assigned bu= s number 5 > [ 22.270160] xhci-hcd ee000000.usb: can't setup: -110 > [ 22.274931] xhci-hcd ee000000.usb: USB bus 5 deregistered > [ 22.280158] xhci-hcd: probe of ee000000.usb failed with error -110 > > The timestamp is strange to me. But, logs of R-Car H3 (ES1.0) and > R-Car H2 were the same. yeah, seems like your system timer is counting twice for each tick. > Should I revise the commit log in detail? Sure, but let's first why this is the case. It's unclear, to me at least, why reset fails. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXGKknAAoJEIaOsuA1yqREJxEP/id5BdfwffRuVHMTI9m1+Xoa 6/1/1QPdZU23HwgCufpLPcQw2ISkoY5yTvN3XFOSTCx6wZ6OnPXhVXFILJLqFuGA x2fePfvyzvzrw1ykt05LWUlL/aUjh9VVtqCP7f0a1P3CA/OpkOH7S/shdOMVmlbt yzJTpFljlaDG198IgD2cfRVF0sNzMNT8D6gJcYhsuIixeYn2PO989fv7otss+nec K/renogrRlhg74Fe2XJoj2XyN3dROm55ZuTHde7cLgusMtCqIMmuC9i+FG+xc5Io cKikzNvbIHChvTKQgY3S8ozKU4UbSVcaO90bU/rES7kT0RhCmHMWZhb5hJXJPN00 /1YwU7zdMgzEOH0pnLTUEL3giShH/AXEwCHbP6/FmMlJPoJ3Ys+X6IAJNXQt6mbC hlp63ZrSg/IQzZ5KhgPzYgLn9fBUdAlcdwZTqMkuoP86dhWZ2cZlNI4OyixKCfE4 K6tyRhWLAdD8z9651ERecglmbwZYg+B98YDlIco19SnIjcDChW9Ix3d55Ubod4YM eU7Z1KWvhJ/72YNBhQkR2W4EnPZSYts0B9pkGVwIvnWyy3v8LRA7uFcB0Rtk9jXo MrO8kKATJPz+9zBnJ9UCm9hrSrgoZQPyxPjL2JcOk6+jhg/C6bRR9Swcf0r8wlh6 qpD8jqVz0sd6vC5RceWz =It+u -----END PGP SIGNATURE----- --=-=-=--