[PATCH 1/8] drm/i915/bios: parse DDI ports also for CHV for HDMI DDC pin and DP AUX channel

[PATCH 1/8] drm/i915/bios: parse DDI ports also for CHV for HDMI DDC pin and DP AUX channel

[Jani Nikula]

While technically CHV isn't DDI, we do look at the VBT based DDI port
info for HDMI DDC pin and DP AUX channel. (We call these "alternate",
but they're really just something that aren't platform defaults.)

In commit e4ab73a13291 ("drm/i915: Respect alternate_ddc_pin for all DDI
ports") Ville writes, "IIRC there may be CHV system that might actually
need this."

I'm not sure why there couldn't be even more platforms that need this,
but start conservative, and parse the info for CHV in addition to DDI.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100553
Reported-by: Marek Wilczewski <mw@3cte.pl>
Cc: stable@vger.kernel.org
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/intel_bios.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index 3747d8df0175..6b8d396ab605 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -1247,7 +1247,7 @@ static void parse_ddi_ports(struct drm_i915_private *dev_priv,
 {
 	enum port port;
 
-	if (!HAS_DDI(dev_priv))
+	if (!HAS_DDI(dev_priv) && !IS_CHERRYVIEW(dev_priv))
 		return;
 
 	if (!dev_priv->vbt.child_dev_num)
-- 
2.11.0

Re: [PATCH 1/8] drm/i915/bios: parse DDI ports also for CHV for HDMI DDC pin and DP AUX channel

[Ville Syrjälä]

On Thu, Sep 28, 2017 at 11:21:57AM +0300, Jani Nikula wrote:
> While technically CHV isn't DDI, we do look at the VBT based DDI port
> info for HDMI DDC pin and DP AUX channel. (We call these "alternate",
> but they're really just something that aren't platform defaults.)
> 
> In commit e4ab73a13291 ("drm/i915: Respect alternate_ddc_pin for all DDI
> ports") Ville writes, "IIRC there may be CHV system that might actually
> need this."
> 
> I'm not sure why there couldn't be even more platforms that need this,
> but start conservative, and parse the info for CHV in addition to DDI.

Going back as far as VLV might make some sense since it came out at around
the same time as HSW, and IIRC the VBT versions seen on VLV and HSW are
more less the same.

Series lgtm
Reviewed-by: Ville Syrj�l� <ville.syrjala@linux.intel.com>

> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100553
> Reported-by: Marek Wilczewski <mw@3cte.pl>
> Cc: stable@vger.kernel.org
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_bios.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> index 3747d8df0175..6b8d396ab605 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -1247,7 +1247,7 @@ static void parse_ddi_ports(struct drm_i915_private *dev_priv,
>  {
>  	enum port port;
>  
> -	if (!HAS_DDI(dev_priv))
> +	if (!HAS_DDI(dev_priv) && !IS_CHERRYVIEW(dev_priv))
>  		return;
>  
>  	if (!dev_priv->vbt.child_dev_num)
> -- 
> 2.11.0

-- 
Ville Syrj�l�
Intel OTC

Re: [PATCH 1/8] drm/i915/bios: parse DDI ports also for CHV for HDMI DDC pin and DP AUX channel

[Jani Nikula]

On Mon, 09 Oct 2017, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Thu, Sep 28, 2017 at 11:21:57AM +0300, Jani Nikula wrote:
>> While technically CHV isn't DDI, we do look at the VBT based DDI port
>> info for HDMI DDC pin and DP AUX channel. (We call these "alternate",
>> but they're really just something that aren't platform defaults.)
>> 
>> In commit e4ab73a13291 ("drm/i915: Respect alternate_ddc_pin for all DDI
>> ports") Ville writes, "IIRC there may be CHV system that might actually
>> need this."
>> 
>> I'm not sure why there couldn't be even more platforms that need this,
>> but start conservative, and parse the info for CHV in addition to DDI.
>
> Going back as far as VLV might make some sense since it came out at around
> the same time as HSW, and IIRC the VBT versions seen on VLV and HSW are
> more less the same.

Let's do that later as needed.

> Series lgtm
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Pushed all to dinq, thanks for the review.

BR,
Jani.


>
>> 
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100553
>> Reported-by: Marek Wilczewski <mw@3cte.pl>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_bios.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
>> index 3747d8df0175..6b8d396ab605 100644
>> --- a/drivers/gpu/drm/i915/intel_bios.c
>> +++ b/drivers/gpu/drm/i915/intel_bios.c
>> @@ -1247,7 +1247,7 @@ static void parse_ddi_ports(struct drm_i915_private *dev_priv,
>>  {
>>  	enum port port;
>>  
>> -	if (!HAS_DDI(dev_priv))
>> +	if (!HAS_DDI(dev_priv) && !IS_CHERRYVIEW(dev_priv))
>>  		return;
>>  
>>  	if (!dev_priv->vbt.child_dev_num)
>> -- 
>> 2.11.0

-- 
Jani Nikula, Intel Open Source Technology Center