stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: ville.syrjala@linux.intel.com, linux-gpio@vger.kernel.org
Cc: Alexandre Courbot <gnurou@gmail.com>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Shobhit Kumar <shobhit.kumar@intel.com>,
	intel-gfx@lists.freedesktop.org, stable@vger.kernel.org,
	Thierry Reding <thierry.reding@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [Intel-gfx] [PATCH] mfd: intel_soc_pmic_core: Terminate panel	control GPIO lookup table correctly
Date: Mon, 25 Apr 2016 10:40:57 +0300	[thread overview]
Message-ID: <8737qam8za.fsf@intel.com> (raw)
In-Reply-To: <1461353935-8078-1-git-send-email-ville.syrjala@linux.intel.com>

On Fri, 22 Apr 2016, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> GPIO lookup tables are supposed to be zero terminated. Let's do that
> and avoid accidentally walking off the end.
>
> Cc: Shobhit Kumar <shobhit.kumar@intel.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: stable@vger.kernel.org
> Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/mfd/intel_soc_pmic_core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c
> index d9e15cf7c6c8..12d6ebb4ae5d 100644
> --- a/drivers/mfd/intel_soc_pmic_core.c
> +++ b/drivers/mfd/intel_soc_pmic_core.c
> @@ -35,6 +35,7 @@ static struct gpiod_lookup_table panel_gpio_table = {
>  	.table = {
>  		/* Panel EN/DISABLE */
>  		GPIO_LOOKUP("gpio_crystalcove", 94, "panel", GPIO_ACTIVE_HIGH),
> +		{ },
>  	},
>  };

-- 
Jani Nikula, Intel Open Source Technology Center

  reply	other threads:[~2016-04-25  7:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-22 19:38 [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly ville.syrjala
2016-04-25  7:40 ` Jani Nikula [this message]
2016-04-25 10:06 ` Thierry Reding
2016-04-29  9:31 ` Linus Walleij
2016-05-02  8:19   ` [Intel-gfx] " Daniel Vetter
2016-05-04  7:32     ` Lee Jones
2016-05-09  6:57       ` Daniel Vetter
2016-05-09  7:17         ` Lee Jones
2016-05-09  7:18 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8737qam8za.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=gnurou@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=shobhit.kumar@intel.com \
    --cc=stable@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).