* [PATCH 1/2] net: Check the correct namespace when spoofing pid over SCM_RIGHTS [not found] <cover.1377196394.git.luto@amacapital.net> @ 2013-08-22 18:39 ` Andy Lutomirski 2013-08-27 1:02 ` Eric W. Biederman 0 siblings, 1 reply; 2+ messages in thread From: Andy Lutomirski @ 2013-08-22 18:39 UTC (permalink / raw) To: Eric W. Biederman, security; +Cc: linux-kernel, netdev, Andy Lutomirski, stable This is a security bug. The follow-up will fix nsproxy to discourage this type of issue from happening again. Cc: stable@vger.kernel.org Signed-off-by: Andy Lutomirski <luto@amacapital.net> --- net/core/scm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/scm.c b/net/core/scm.c index 03795d0..b4da80b 100644 --- a/net/core/scm.c +++ b/net/core/scm.c @@ -54,7 +54,7 @@ static __inline__ int scm_check_creds(struct ucred *creds) return -EINVAL; if ((creds->pid == task_tgid_vnr(current) || - ns_capable(current->nsproxy->pid_ns->user_ns, CAP_SYS_ADMIN)) && + ns_capable(task_active_pid_ns(current)->user_ns, CAP_SYS_ADMIN)) && ((uid_eq(uid, cred->uid) || uid_eq(uid, cred->euid) || uid_eq(uid, cred->suid)) || nsown_capable(CAP_SETUID)) && ((gid_eq(gid, cred->gid) || gid_eq(gid, cred->egid) || -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] net: Check the correct namespace when spoofing pid over SCM_RIGHTS 2013-08-22 18:39 ` [PATCH 1/2] net: Check the correct namespace when spoofing pid over SCM_RIGHTS Andy Lutomirski @ 2013-08-27 1:02 ` Eric W. Biederman 0 siblings, 0 replies; 2+ messages in thread From: Eric W. Biederman @ 2013-08-27 1:02 UTC (permalink / raw) To: Andy Lutomirski; +Cc: security, linux-kernel, netdev, stable Andy Lutomirski <luto@amacapital.net> writes: > This is a security bug. > > The follow-up will fix nsproxy to discourage this type of issue from > happening again. Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com> > > Cc: stable@vger.kernel.org > Signed-off-by: Andy Lutomirski <luto@amacapital.net> > --- > net/core/scm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/scm.c b/net/core/scm.c > index 03795d0..b4da80b 100644 > --- a/net/core/scm.c > +++ b/net/core/scm.c > @@ -54,7 +54,7 @@ static __inline__ int scm_check_creds(struct ucred *creds) > return -EINVAL; > > if ((creds->pid == task_tgid_vnr(current) || > - ns_capable(current->nsproxy->pid_ns->user_ns, CAP_SYS_ADMIN)) && > + ns_capable(task_active_pid_ns(current)->user_ns, CAP_SYS_ADMIN)) && > ((uid_eq(uid, cred->uid) || uid_eq(uid, cred->euid) || > uid_eq(uid, cred->suid)) || nsown_capable(CAP_SETUID)) && > ((gid_eq(gid, cred->gid) || gid_eq(gid, cred->egid) || ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-27 1:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1377196394.git.luto@amacapital.net>
2013-08-22 18:39 ` [PATCH 1/2] net: Check the correct namespace when spoofing pid over SCM_RIGHTS Andy Lutomirski
2013-08-27 1:02 ` Eric W. Biederman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).