Re: [PATCH] mtd: rawnand: fsmc: Default to autodetect buswidth

[Miquel Raynal <miquel.raynal@bootlin.com>]

On 16/09/2025 at 20:49:25 +02, Linus Walleij <linus.walleij@linaro.org> wrote:

> On Tue, Sep 16, 2025 at 11:33 AM Miquel Raynal
> <miquel.raynal@bootlin.com> wrote:
>> On 14/09/2025 at 00:35:37 +02, Linus Walleij <linus.walleij@linaro.org> wrote:
>
>> > I don't know where or how this happened, I think some change
>> > in the nand core.
>>
>> I had a look and honnestly could not find where we broke this. Could it
>> be possible that it never worked with DT probing and only with platform
>> data? Any idea of what was the previously working base?
>
> I tested old kernels back to 4.20 and it didn't work.
> Probably it never worked?

Ah :-) Might make sense!

> I tried to recompile something further back but I don't
> have the required old toolchains around :P

Yeah, no pb. As you said, we probably never faced the issue even though
it was latent.

>> Anyhow, this is just curiosity, patch is relevant (just a little nit
>> below?).
>> > +             };
>>
>>                  ^
>> There is a spurious ';' here, no?
>
> Fixed in v2, also made a more elaborate handling if someone
> would explicitly set the width to 2.
>
> I think the SPEAr that is the primary user always sets the width
> to 2 so they never saw this bug.

Certainly.

Thanks!
Miquèl