From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mga18.intel.com ([134.134.136.126]:31180 "EHLO mga18.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933939AbeF2GYW (ORCPT <rfc822;stable@vger.kernel.org>);
        Fri, 29 Jun 2018 02:24:22 -0400
From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: liangshengjun <liangshengjun@hisilicon.com>,
        Alan Stern <stern@rowland.harvard.edu>
Cc: "stable\@vger.kernel.org" <stable@vger.kernel.org>,
        "linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: =?utf-8?B?562U5aSNOg==?= make a confirm for  [usb: dwc3:
 gadget: skip Set/Clear Halt when invalid]
In-Reply-To: <84923CA334DF85428B9ADCEC0F3CE864BA1EA4@dggemm510-mbx.china.huawei.com>
References: <Pine.LNX.4.44L0.1806211127520.2381-100000@iolanthe.rowland.org> <878t73ux28.fsf@linux.intel.com> <84923CA334DF85428B9ADCEC0F3CE864BA1EA4@dggemm510-mbx.china.huawei.com>
Date: Fri, 29 Jun 2018 09:21:14 +0300
Message-ID: <874lhmf6zp.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>


(no top-posting!!)

liangshengjun <liangshengjun@hisilicon.com> writes:

> Hi balbi,
>
> It means that the mainline keep checking stall status first before
> handle clear-halt request?  as usb spec, it's actually okay to send
> Clear Halt at any time. But dwc3 core hanging with macOS adb
> application, so I think there is other rootcase why dwc3 hanging , and
> current patch just for avoid this case. Right?

that's correct. There's another problem happening that causes dwc3 to
hang. I guess I'll just revert that patch since it causes more problems
than solve.

> If someday WindonwPC/LINUX PC meet this case again liked my case,
> would you plan to revert it ? or other plan ?

I'll just revert it.

-- 
balbi