From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail-wm0-f67.google.com ([74.125.82.67]:35642 "EHLO
	mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751605AbcF1HhA (ORCPT
	<rfc822;stable@vger.kernel.org>); Tue, 28 Jun 2016 03:37:00 -0400
From: Holger Schurig <holgerschurig@gmail.com>
To: Oliver Hartkopp <socketcan@hartkopp.net>,
	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>, netdev@vger.kernel.org
Cc: davem@davemloft.net, linux-can@vger.kernel.org,
	kernel@pengutronix.de, stable@vger.kernel.org
Subject: Re: [PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage
In-Reply-To: <a1bd95b5-ea93-0e99-7784-dad393240f06@hartkopp.net>
References: <1466673741-23115-1-git-send-email-mkl@pengutronix.de> <1466673741-23115-3-git-send-email-mkl@pengutronix.de> <e092c3e9-56f3-f765-a9ef-89697ec46e16@cogentembedded.com> <0e51107f-a381-6c94-0079-d0ed415d8bcc@hartkopp.net> <f4b685f9-a2ad-d3cc-1204-f457705467df@cogentembedded.com> <a1bd95b5-ea93-0e99-7784-dad393240f06@hartkopp.net>
Date: Tue, 28 Jun 2016 09:36:57 +0200
Message-ID: <874m8d7oiu.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

> static void can_dellink(struct net_device *dev, struct list_head *head);
>
> and
>
> static void can_dellink(struct net_device *dev, struct list_head *head)
> {
> 	return;
> }

Wouldn't the canonical form be this:

static void can_dellink(struct net_device *dev, struct list_head *head)
{
}


- the curly braces make sure this isn't a forward definition
- but no useless return either


But then again, this "return" is only cosmetical. No compiler will
generate any code from it.