From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com ([134.134.136.65]:24126 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751008AbcDUKHJ (ORCPT ); Thu, 21 Apr 2016 06:07:09 -0400 From: Felipe Balbi To: Yoshihiro Shimoda , mathias.nyman@intel.com, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org, stable@vger.kernel.org, Yoshihiro Shimoda Subject: Re: [PATCH] usb: host: xhci-rcar: Avoid long wait in xhci_reset() In-Reply-To: <1461232154-7420-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> References: <1461232154-7420-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> Date: Thu, 21 Apr 2016 13:04:55 +0300 Message-ID: <874mavb7lk.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: stable-owner@vger.kernel.org List-ID: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Yoshihiro Shimoda writes: > If kernel configuration is CONFIG_USB_XHCI_PLATFORM=3Dy and > CONFIG_USB_XHCI_RCAR is not set, R-Car Gen2/3 will cause long wait > in xhci_reset() because such SoCs need specific initialization. where is the delay coming from exactly ? > So, this patch modifies the xhci_rcar_init_quirk() in xhci-rcar.h > to exit the probe function immediately. > > Fixes: 4ac8918f3a7 (usb: host: xhci-plat: add support for the R-Car H2 an= d M2 xHCI controllers) > Cc: # v3.17+ > Signed-off-by: Yoshihiro Shimoda > --- > drivers/usb/host/xhci-rcar.h | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/host/xhci-rcar.h b/drivers/usb/host/xhci-rcar.h > index 2941a25..2afed68 100644 > --- a/drivers/usb/host/xhci-rcar.h > +++ b/drivers/usb/host/xhci-rcar.h > @@ -24,7 +24,11 @@ static inline void xhci_rcar_start(struct usb_hcd *hcd) >=20=20 > static inline int xhci_rcar_init_quirk(struct usb_hcd *hcd) > { > - return 0; > + /* > + * To avoid wait and timeout in xhci_reset() if CONFIG_XHCI_RCAR is > + * disabled, this function fails. > + */ > + return -ENODEV; > } > #endif > #endif /* _XHCI_RCAR_H */ > --=20 > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXGKXIAAoJEIaOsuA1yqRENDkQAJlWKRNSEraMtRV12ll8sPEd eY+3nIxm+xFgjTwxrZD0DcZeVohHJXozvz9dqGylXje85bn1XyDZh4NldAdJBZNO wSdfPqM0Atd6NeHpZhc9NKJH13IQoDZPzvYOWTYK79y/a1oHyLGl/oFfF7MljmEe LQcLj1eL3n0VxOivK1o0FfFXLTOd6PoXT5WdpiF/2hWVEBX4KsV7bjG/cPngcvop ZsRl2Usjw8Fnk+kL83wtaMKOri6Soo3lZwtk8kNZYyq5zPXillsgMcIJ90cV5vSG FQ+gIbVWvpefrNCy4WYdBG7ZDnnTT5YWLyabhzeZe8CfuRGh56+kRkn6excDY/R5 WHaqCa+9V/+NWLmPm3r4jhMDTwL17z91pfcVKLZ8706YNjOratfTUR80jYDNUIvt evhtSCtFsVXTHle0llN97eYp8rmwhYRv5b1dmf+VSc2E/4eAX/TFo+/d3bApFCtc hTw4ryUeB3c3I/+GSc4nxp6yGCD5f5dwO9Wgde/FHwF/apenHLzT7SVEaNFYrpq8 VpRvVb9tCnnxfHsuUaZh0i7rSMqaFTLvbPXib67HAOJHm3Wd/eVw1st/8+H2VXHS Z/Fu0rZYvxiJZRbqIBWzupGEpwgfRgtvSZfd/45kDLSqpgWxP8s19CRYBXZyDLvK CG9wzqGswBNGVC9a8Ceh =QTyy -----END PGP SIGNATURE----- --=-=-=--