From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bootlin.com ([62.4.15.54]:41925 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbeC2OMk (ORCPT ); Thu, 29 Mar 2018 10:12:40 -0400 From: Gregory CLEMENT To: Thomas Petazzoni Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, =?utf-8?Q?Miqu=C3=A8l?= Raynal , Maxime Chevallier , Antoine Tenart , Victor Gu , Nadav Haklai , linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH v4 2/6] PCI: aardvark: Fix logic in advk_pcie_valid_device() References: <20180329083946.25970-1-thomas.petazzoni@bootlin.com> <20180329083946.25970-3-thomas.petazzoni@bootlin.com> Date: Thu, 29 Mar 2018 16:12:28 +0200 In-Reply-To: <20180329083946.25970-3-thomas.petazzoni@bootlin.com> (Thomas Petazzoni's message of "Thu, 29 Mar 2018 10:39:42 +0200") Message-ID: <87605ft1gz.fsf@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain Sender: stable-owner@vger.kernel.org List-ID: Hi Thomas, On jeu., mars 29 2018, Thomas Petazzoni wrote: > From: Victor Gu > > The PCI configuration space read/write functions were special casing causing? else I don't get it > the situation where PCI_SLOT(devfn) != 0, and returned > PCIBIOS_DEVICE_NOT_FOUND in this case. > > However, while this is what is intended for the root bus, it is not > intended for the child busses, as it prevents discovering devices with buses > PCI_SLOT(x) != 0. Therefore, we return PCIBIOS_DEVICE_NOT_FOUND only > if we're on the root bus. > Gregory -- Gregory Clement, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com