From: "Cássio Gabriel Monteiro Pires" <cassiogabrielcontato@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+8fa95c41eafbc9d2ff6f@syzkaller.appspotmail.com,
stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: aloop: Fix peer runtime UAF during format-change stop
Date: Fri, 24 Apr 2026 09:14:00 -0300 [thread overview]
Message-ID: <87797cae-2716-48e2-b0ba-47cdfb34645f@gmail.com> (raw)
In-Reply-To: <87se8k1ugc.wl-tiwai@suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 516 bytes --]
On 4/24/26 08:14, Takashi Iwai wrote:
> Do we need to complicate this handling? IOW, can it be simply be like
> below?
>
> if (stop_capture) {
> snd_pcm_stop(dpcm_capt->substream, SNDRV_PCM_STATE_DRAINING);
> if (atomic_dec_and_test(&cable->stop_count))
> wake_up(&cable->stop_wait);
> }
That makes sense.
The lifetime fix only needs the stop_count/stop_wait
serialization, so I can simplify the stop path as you suggested.
I'll respin and send a v2 patch.
--
Thanks,
Cássio
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
prev parent reply other threads:[~2026-04-24 12:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 3:22 [PATCH] ALSA: aloop: Fix peer runtime UAF during format-change stop Cássio Gabriel
2026-04-24 11:14 ` Takashi Iwai
2026-04-24 12:14 ` Cássio Gabriel Monteiro Pires [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87797cae-2716-48e2-b0ba-47cdfb34645f@gmail.com \
--to=cassiogabrielcontato@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=syzbot+8fa95c41eafbc9d2ff6f@syzkaller.appspotmail.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox