public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] ALSA: hda/realtek: add quirk for HP Victus 15-fb0xxx
@ 2026-03-26 13:43 NonameBlank007
  2026-03-27  9:53 ` Takashi Iwai
  0 siblings, 1 reply; 6+ messages in thread
From: NonameBlank007 @ 2026-03-26 13:43 UTC (permalink / raw)
  To: linux-sound; +Cc: tiwai, stable, NonameBlank007

This adds a mute led quirck for HP Victus 15-fb0xxx (103c:8a3d) model

- As it used 0x8(full bright)/0x7f(little dim) for mute led on and other values as 0ff (0x0, 0x4, ...)

- So, use ALC245_FIXUP_HP_MUTE_LED_V2_COEFBIT insted for safer approach

Cc: <stable@vger.kernel.org>
Signed-off-by: NonameBlank007 <nonameblank007@gmail.com>
---
 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index ab4b22fcb..7f3e88999 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -6954,6 +6954,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8a30, "HP Envy 17", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x103c, 0x8a31, "HP Envy 15", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x103c, 0x8a34, "HP Pavilion x360 2-in-1 Laptop 14-ek0xxx", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
+	SND_PCI_QUIRK(0x103c, 0x8a3d, "HP Victus 15-fb0xxx (MB 8A3D)", ALC245_FIXUP_HP_MUTE_LED_V2_COEFBIT),
 	SND_PCI_QUIRK(0x103c, 0x8a4f, "HP Victus 15-fa0xxx (MB 8A4F)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
 	SND_PCI_QUIRK(0x103c, 0x8a6e, "HP EDNA 360", ALC287_FIXUP_CS35L41_I2C_4),
 	SND_PCI_QUIRK(0x103c, 0x8a74, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] ALSA: hda/realtek: add quirk for HP Victus 15-fb0xxx
  2026-03-26 13:43 [PATCH 1/1] ALSA: hda/realtek: add quirk for HP Victus 15-fb0xxx NonameBlank007
@ 2026-03-27  9:53 ` Takashi Iwai
  2026-03-27 12:01   ` Sourav Nayak
  0 siblings, 1 reply; 6+ messages in thread
From: Takashi Iwai @ 2026-03-27  9:53 UTC (permalink / raw)
  To: NonameBlank007; +Cc: linux-sound, tiwai, stable

On Thu, 26 Mar 2026 14:43:24 +0100,
NonameBlank007 wrote:
> 
> This adds a mute led quirck for HP Victus 15-fb0xxx (103c:8a3d) model
> 
> - As it used 0x8(full bright)/0x7f(little dim) for mute led on and other values as 0ff (0x0, 0x4, ...)
> 
> - So, use ALC245_FIXUP_HP_MUTE_LED_V2_COEFBIT insted for safer approach
> 
> Cc: <stable@vger.kernel.org>
> Signed-off-by: NonameBlank007 <nonameblank007@gmail.com>

Please use a real name or a known identity for Signed-off-by line as
it's a legal requirement.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/1] ALSA: hda/realtek: add quirk for HP Victus 15-fb0xxx
  2026-03-27  9:53 ` Takashi Iwai
@ 2026-03-27 12:01   ` Sourav Nayak
  2026-03-27 12:45     ` Greg KH
  0 siblings, 1 reply; 6+ messages in thread
From: Sourav Nayak @ 2026-03-27 12:01 UTC (permalink / raw)
  To: tiwai; +Cc: linux-sound, nonameblank007, stable, tiwai

From: NonameBlank007 <nonameblank007@gmail.com>

This adds a mute led quirck for HP Victus 15-fb0xxx (103c:8a3d) model

- As it used 0x8(full bright)/0x7f(little dim) for mute led on and other values as 0ff (0x0, 0x4, ...)

- So, use ALC245_FIXUP_HP_MUTE_LED_V2_COEFBIT insted for safer approach

Cc: <stable@vger.kernel.org>
Signed-off-by: Sourav Nayak <nonameblank007@gmail.com>
---
 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index ab4b22fcb..7f3e88999 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -6954,6 +6954,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8a30, "HP Envy 17", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x103c, 0x8a31, "HP Envy 15", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x103c, 0x8a34, "HP Pavilion x360 2-in-1 Laptop 14-ek0xxx", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
+	SND_PCI_QUIRK(0x103c, 0x8a3d, "HP Victus 15-fb0xxx (MB 8A3D)", ALC245_FIXUP_HP_MUTE_LED_V2_COEFBIT),
 	SND_PCI_QUIRK(0x103c, 0x8a4f, "HP Victus 15-fa0xxx (MB 8A4F)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
 	SND_PCI_QUIRK(0x103c, 0x8a6e, "HP EDNA 360", ALC287_FIXUP_CS35L41_I2C_4),
 	SND_PCI_QUIRK(0x103c, 0x8a74, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] ALSA: hda/realtek: add quirk for HP Victus 15-fb0xxx
  2026-03-27 12:01   ` Sourav Nayak
@ 2026-03-27 12:45     ` Greg KH
  2026-03-27 14:18       ` NonameBlank007
  0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2026-03-27 12:45 UTC (permalink / raw)
  To: Sourav Nayak; +Cc: tiwai, linux-sound, stable, tiwai

On Fri, Mar 27, 2026 at 05:31:49PM +0530, Sourav Nayak wrote:
> From: NonameBlank007 <nonameblank007@gmail.com>

This doesn't seem to match:

> Signed-off-by: Sourav Nayak <nonameblank007@gmail.com>

^that :(


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] ALSA: hda/realtek: add quirk for HP Victus 15-fb0xxx
  2026-03-27 12:45     ` Greg KH
@ 2026-03-27 14:18       ` NonameBlank007
  2026-03-27 14:28         ` Sourav Nayak
  0 siblings, 1 reply; 6+ messages in thread
From: NonameBlank007 @ 2026-03-27 14:18 UTC (permalink / raw)
  To: Greg KH; +Cc: tiwai, linux-sound, stable, tiwai

Really sorry about that it's my first time and i wasn't aware of such case.

I changed it because of this,

> >
> > Please use a real name or a known identity for Signed-off-by line as
it's a legal requirement.
> >
> >
> > thanks,
> >
> > Takashi
>

I apologise for the trouble caused, and would be mindful next time.

Thanks,

Sourav


On Fri, 27 Mar 2026 at 18:16, Greg KH <greg@kroah.com> wrote:
>
> On Fri, Mar 27, 2026 at 05:31:49PM +0530, Sourav Nayak wrote:
> > From: NonameBlank007 <nonameblank007@gmail.com>
>
> This doesn't seem to match:
>
> > Signed-off-by: Sourav Nayak <nonameblank007@gmail.com>
>
> ^that :(
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/1] ALSA: hda/realtek: add quirk for HP Victus 15-fb0xxx
  2026-03-27 14:18       ` NonameBlank007
@ 2026-03-27 14:28         ` Sourav Nayak
  0 siblings, 0 replies; 6+ messages in thread
From: Sourav Nayak @ 2026-03-27 14:28 UTC (permalink / raw)
  To: nonameblank007; +Cc: greg, linux-sound, stable, tiwai, tiwai

This adds a mute led quirck for HP Victus 15-fb0xxx (103c:8a3d) model

- As it used 0x8(full bright)/0x7f(little dim) for mute led on and other values as 0ff (0x0, 0x4, ...)

- So, use ALC245_FIXUP_HP_MUTE_LED_V2_COEFBIT insted for safer approach

Cc: <stable@vger.kernel.org>
Signed-off-by: Sourav Nayak <nonameblank007@gmail.com>
---
 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index ab4b22fcb..7f3e88999 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -6954,6 +6954,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8a30, "HP Envy 17", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x103c, 0x8a31, "HP Envy 15", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x103c, 0x8a34, "HP Pavilion x360 2-in-1 Laptop 14-ek0xxx", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
+	SND_PCI_QUIRK(0x103c, 0x8a3d, "HP Victus 15-fb0xxx (MB 8A3D)", ALC245_FIXUP_HP_MUTE_LED_V2_COEFBIT),
 	SND_PCI_QUIRK(0x103c, 0x8a4f, "HP Victus 15-fa0xxx (MB 8A4F)", ALC245_FIXUP_HP_MUTE_LED_COEFBIT),
 	SND_PCI_QUIRK(0x103c, 0x8a6e, "HP EDNA 360", ALC287_FIXUP_CS35L41_I2C_4),
 	SND_PCI_QUIRK(0x103c, 0x8a74, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-03-27 14:28 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-26 13:43 [PATCH 1/1] ALSA: hda/realtek: add quirk for HP Victus 15-fb0xxx NonameBlank007
2026-03-27  9:53 ` Takashi Iwai
2026-03-27 12:01   ` Sourav Nayak
2026-03-27 12:45     ` Greg KH
2026-03-27 14:18       ` NonameBlank007
2026-03-27 14:28         ` Sourav Nayak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox