From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE49DC433B4 for ; Sat, 15 May 2021 13:07:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E33561363 for ; Sat, 15 May 2021 13:07:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231173AbhEONIT (ORCPT ); Sat, 15 May 2021 09:08:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:59700 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231217AbhEONIL (ORCPT ); Sat, 15 May 2021 09:08:11 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 05142611C9; Sat, 15 May 2021 13:06:59 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lhu0O-001YG2-TN; Sat, 15 May 2021 14:06:57 +0100 Date: Sat, 15 May 2021 14:06:56 +0100 Message-ID: <877dk05eof.wl-maz@kernel.org> From: Marc Zyngier To: Sasha Levin Cc: stable-commits@vger.kernel.org, stable , Mark Rutland Subject: Re: Patch "arm64: entry: factor irq triage logic into macros" has been added to the 5.12-stable tree In-Reply-To: References: <20210515021826.35E98613F2@mail.kernel.org> <87a6ow5lg2.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: sashal@kernel.org, stable-commits@vger.kernel.org, stable@vger.kernel.org, mark.rutland@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Sat, 15 May 2021 13:37:51 +0100, Sasha Levin wrote: > > On Sat, May 15, 2021 at 11:40:45AM +0100, Marc Zyngier wrote: > > Hi Sasha, > > > > On Sat, 15 May 2021 03:18:25 +0100, > > Sasha Levin wrote: > >> > >> This is a note to let you know that I've just added the patch titled > >> > >> arm64: entry: factor irq triage logic into macros > >> > >> to the 5.12-stable tree which can be found at: > >> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > >> > >> The filename of the patch is: > >> arm64-entry-factor-irq-triage-logic-into-macros.patch > >> and it can be found in the queue-5.12 subdirectory. > >> > >> If you, or anyone else, feels it should not be added to the stable tree, > >> please let know about it. > >> > >> > >> > >> commit ec301e4d131aad1648e28305c8d02ae8265a50d7 > >> Author: Marc Zyngier > >> Date: Mon Mar 15 11:56:27 2021 +0000 > >> > >> arm64: entry: factor irq triage logic into macros > >> > >> [ Upstream commit 9eb563cdabe1d583c262042d5d44cc256f644543 ] > >> > >> In subsequent patches we'll allow an FIQ handler to be registered, and > >> FIQ exceptions will need to be triaged very similarly to IRQ exceptions. > >> So that we can reuse the existing logic, this patch factors the IRQ > >> triage logic out into macros that can be reused for FIQ. > >> > >> The macros are named to follow the elX_foo_handler scheme used by the C > >> exception handlers. For consistency with other top-level exception > >> handlers, the kernel_entry/kernel_exit logic is not moved into the > >> macros. As FIQ will use a different C handler, this handler name is > >> provided as an argument to the macros. > >> > >> There should be no functional change as a result of this patch. > >> > >> Signed-off-by: Marc Zyngier > >> [Mark: rework macros, commit message, rebase before DAIF rework] > >> Signed-off-by: Mark Rutland > >> Tested-by: Hector Martin > >> Cc: James Morse > >> Cc: Thomas Gleixner > >> Cc: Will Deacon > >> Acked-by: Will Deacon > >> Link: https://lore.kernel.org/r/20210315115629.57191-5-mark.rutland@arm.com > >> Signed-off-by: Catalin Marinas > >> Signed-off-by: Sasha Levin > > > > I don't think there is any reason for backporting this patch at this > > stage. It isn't a fix, and we don't plan to support the feature it > > subsequently enables in anything older than 5.13. > > > > Unless there is a another pressing reason for adding this patch, I > > suggest it is dropped from 5.10, 5.11 and 5.12 stable branches. > > Actually, looks like I took it to make 4d6a38da8e79 ("arm64: entry: > always set GIC_PRIO_PSR_I_SET during entry") apply easier, does it make > sense to keep it in this scenario? Ah, right. In this case, it indeed makes sense to keep it. Thanks for the clarification, M. -- Without deviation from the norm, progress is not possible.