From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com ([134.134.136.65]:3821 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750926AbdDDIJU (ORCPT ); Tue, 4 Apr 2017 04:09:20 -0400 From: Felipe Balbi To: Linux USB , John Youn Cc: stable@vger.kernel.org Subject: Re: [PATCH] usb: dwc3: gadget: skip Set/Clear Halt when invalid In-Reply-To: <20170119114034.15184-1-felipe.balbi@linux.intel.com> References: <20170119114034.15184-1-felipe.balbi@linux.intel.com> Date: Tue, 04 Apr 2017 11:09:04 +0300 Message-ID: <877f30iogv.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: stable-owner@vger.kernel.org List-ID: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi John, Felipe Balbi writes: > At least macOS seems to be sending > ClearFeature(ENDPOINT_HALT) to endpoints which > aren't Halted. This makes DWC3's CLEARSTALL command > time out which causes several issues for the driver. > > Instead, let's just return 0 and bail out early. > > Cc: > Signed-off-by: Felipe Balbi > --- > > this falls into "has never worked before" category, so I'll be sending > it together with other patches for v4.11 merge window. Still, it's a > valid bug that's likely needed for stable trees. > > drivers/usb/dwc3/gadget.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > index 6faf484e5dfc..0a664d8eba3f 100644 > --- a/drivers/usb/dwc3/gadget.c > +++ b/drivers/usb/dwc3/gadget.c > @@ -1379,6 +1379,9 @@ int __dwc3_gadget_ep_set_halt(struct dwc3_ep *dep, = int value, int protocol) > unsigned transfer_in_flight; > unsigned started; >=20=20 > + if (dep->flags & DWC3_EP_STALL) > + return 0; > + > if (dep->number > 1) > trb =3D dwc3_ep_prev_trb(dep, dep->trb_enqueue); > else > @@ -1400,6 +1403,8 @@ int __dwc3_gadget_ep_set_halt(struct dwc3_ep *dep, = int value, int protocol) > else > dep->flags |=3D DWC3_EP_STALL; > } else { > + if (!(dep->flags & DWC3_EP_STALL)) > + return 0; >=20=20 > ret =3D dwc3_send_clear_stall_ep_cmd(dep); > if (ret) Reviving this old thread here. While $subject allowed dwc3 to work when attached to macOS Host, I fear that we might have more issues than not in the future. The reason is that USB20 spec allows hosts to use ClearFeature(ENDPOINT_HALT) as a "Reset Data Toggle/SeqN" hint. With this, we're basically blocking that possibility. Still, without $subject, ClearStall commands were timing out. I'll try to do a local revert here and check what happens in this case, but would you have any idea why ClearStall would time out like that? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAljjVKAACgkQzL64meEa mQbZyhAA0zC117K23/CK70ebbDNNCPpO03P3UFvW8HwXCCR/FcCqVSF97y2XmDNS tyIj7nI56xj1pGrLkLvyPtMkEIDvUYUTdehGHtT7Qm2tUtPn999bQ82i11lurLk2 w44WEtWTeQoPzSGVKezy0pfOjK0cEvIU9xA2Q2gjR/GKeT9tyXm++gZDPSx376ml l9IcGvk6mXgQ93FEYQtjots2w2VLGTR6t55InUHJtzAgZfZg0qJJs5oar+WzDtiO MwVfiZ9EmHxTCzrMkmsZrG8iur4oFbdf1B88tmaa4mCcjDu84scR261AkDsdK9Ln 4ocMzHiXYCfW2mqmwmBjDTw/G2ldUMaM5sQsfDAWZgNRaZO5PZJHZF7Xp0sUaCAO R9D1W0bQknmDwSS4dLFkh0nBlwkDYHa0CpkwfZjxXu7N8cQfcFNPULDAopziRngn WkgGwT8Kyokd6eDJYol8uIOo4jr6kKfE2ZQeLXtFoGVuUQeTrQL8Psu87jAZ73mS eQ9GdRkCgPXX3bZK3YYiV5RYsiNuo9DPR/9ts3txSgemZyLgJQed4k0koc1WaaAt Gg7VWnEburbNBEBiekyHDxgDBQYl/kHexMdtMxQX1EwoMZ0jMjOWOsNi87GQP0x+ S0QgQw/ML7N+3qKSZfLLRZbVd2Ha46vfpBb34n1LB6zFAvhv9vE= =Lla9 -----END PGP SIGNATURE----- --=-=-=--