From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com ([134.134.136.31]:29984 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752280AbcKGMju (ORCPT ); Mon, 7 Nov 2016 07:39:50 -0500 From: Felipe Balbi To: David Miller Cc: hzpeterchen@gmail.com, linux-usb@vger.kernel.org, ville.syrjala@linux.intel.com, stable@vger.kernel.org Subject: Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling In-Reply-To: <20161103.130402.357203788680388748.davem@davemloft.net> References: <20161102.112254.1243059410485662386.davem@davemloft.net> <20161103002300.GA894@b29397-desktop> <87wpglqc15.fsf@linux.intel.com> <20161103.130402.357203788680388748.davem@davemloft.net> Date: Mon, 07 Nov 2016 14:39:21 +0200 Message-ID: <877f8fjwg6.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: stable-owner@vger.kernel.org List-ID: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, David Miller writes: > From: Felipe Balbi > Date: Thu, 03 Nov 2016 09:04:54 +0200 > >> What Dave Miller is saying is that it's ALWAYS a bug to delay >> completion of SKBs. The only thing you're doing with chipidea is >> delaying interrupt by up to 125us; which is still a bug from the >> point of view of the networking layer, but it's more difficult to >> perceive any problems because of the short time where interrupt is >> delayed. > > I didn't say delaying was illegal. > > I said that the SKB free must occur in a reasonable, finite, amount of > time. "reasonable" is rather subjective. Completions are, of course, finite. It just means that once a transfer completes *and* has interrupt enabled, then several other SKBs will be completed along with it. That doesn't mean *all* SKBs completed at the same time, it means once we get an interrupt, we give back all previous ones, but we don't know exactly when they completed. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYIHX5AAoJEMy+uJnhGpkGfI4P/2b26BEF5zSVm9Uta2EFh2U3 0tb44bAOuLPha/cbvpAF4HYWaRMuIEPak8mo8fjnPnI8KJma3UZH1of9gSZIqnzm McqbKOKvXJROSwP8dLRv2XOvAPaWzslDuvM1MktMHzvksuTiqIinB/WdJkYPaAup 7h8eiFAvcNpggp32HGM25RCwv3UMjE1M1hnzc6SUgaL/UIvp2jU7dibpveG5FndC OvvFbojzIRsiWDixqn4QkpDO/wbNQdOlOaq4E0vVnaQBLI2ptk6P0WvVzcBCHk35 mzgFLeLasuH+XUlrDoJf97snxsdt63uoKHNY5YikKkKzOZz243+fk+42S06Hubnr YfIEjIW8UVNtg6xzB3En92s/84OuWW6Ll1Lav6EHPE4oJlBZVIIOILsv33MiQIbX UDe/G5qo2j9rfo7x4gMLW6MZmLLYyGuGWuT2bcZCgOvrYQmPPLrjbqggK+BOeGPz ry5LbxdQZP6AjFqLbFGzmyXgM/6nISw+dWautsKJ92eX+Vzz1bZUJp+ZskbAxJnm 5lnSPZCtv/YF+YnXCVZyznf1LtE1/QCYqsjO+DKSoi8l/u437tc7aeUe9jDdXm6u 4vxumgA9JuW5a3Ve1v5qQNaxdhaLNbr9A2UnKggKwTSZ0yj+rZFMvDYU7SIaoWHy UC9TQ+dkB5NHmQvDd1wX =/P6Q -----END PGP SIGNATURE----- --=-=-=--