From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: liangshengjun <liangshengjun@hisilicon.com>,
"stable\@vger.kernel.org" <stable@vger.kernel.org>,
linux-usb@vger.kernel.org
Subject: Re: make a confirm for [usb: dwc3: gadget: skip Set/Clear Halt when invalid]
Date: Mon, 25 Jun 2018 10:47:43 +0300 [thread overview]
Message-ID: <878t73ux28.fsf@linux.intel.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1806211127520.2381-100000@iolanthe.rowland.org>
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
Hi,
Alan Stern <stern@rowland.harvard.edu> writes:
>> that patch is not 100% correct. You can revert it in your tree. I added
>> that because of a problem I found when running adb against macOS.
>>
>> It's actually okay to send Clear Halt at any time, but for some reason
>> dwc3 was hanging when running adb against macOS.
>
> Note: According to the USB spec it's okay to send Clear-Halt at any
> time. But there are plenty of devices that get upset if they receive
> this message when the endpoint isn't actually halted.
right. The weird thing here is that dwc3 has never suffered from this
until we ran ADB against macOS. That was the only way to get any
problems.
Without clear halt, though, we have no means for syncing data toggle.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-06-25 7:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <84923CA334DF85428B9ADCEC0F3CE864BA1492@dggemm510-mbx.china.huawei.com>
2018-06-21 9:42 ` make a confirm for [usb: dwc3: gadget: skip Set/Clear Halt when invalid] Felipe Balbi
2018-06-21 15:29 ` Alan Stern
2018-06-25 7:47 ` Felipe Balbi [this message]
2018-06-29 2:10 ` 答复: " liangshengjun
2018-06-29 6:21 ` Felipe Balbi
2018-11-16 23:54 ` Thinh Nguyen
2018-11-19 6:35 ` Felipe Balbi
2018-06-25 9:37 liangshengjun
2018-06-25 9:43 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878t73ux28.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=liangshengjun@hisilicon.com \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).