From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mga05.intel.com ([192.55.52.43]:39734 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752484AbeFYHuT (ORCPT <rfc822;stable@vger.kernel.org>);
        Mon, 25 Jun 2018 03:50:19 -0400
From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: liangshengjun <liangshengjun@hisilicon.com>,
        "stable\@vger.kernel.org" <stable@vger.kernel.org>,
        linux-usb@vger.kernel.org
Subject: Re: make a confirm for  [usb: dwc3: gadget: skip Set/Clear Halt when invalid]
In-Reply-To: <Pine.LNX.4.44L0.1806211127520.2381-100000@iolanthe.rowland.org>
References: <Pine.LNX.4.44L0.1806211127520.2381-100000@iolanthe.rowland.org>
Date: Mon, 25 Jun 2018 10:47:43 +0300
Message-ID: <878t73ux28.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Alan Stern <stern@rowland.harvard.edu> writes:
>> that patch is not 100% correct. You can revert it in your tree. I added
>> that because of a problem I found when running adb against macOS.
>>=20
>> It's actually okay to send Clear Halt at any time, but for some reason
>> dwc3 was hanging when running adb against macOS.
>
> Note: According to the USB spec it's okay to send Clear-Halt at any
> time.  But there are plenty of devices that get upset if they receive
> this message when the endpoint isn't actually halted.

right. The weird thing here is that dwc3 has never suffered from this
until we ran ADB against macOS. That was the only way to get any
problems.

Without clear halt, though, we have no means for syncing data toggle.

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlswnh8ACgkQzL64meEa
mQZ/kA/8COaf7Oky6kHe3BCD2OtcCD6TzuxGJ88/Qqg7Ob9VXhhLyIZio9wPZ0nO
JYJ4L4W2TU1LH7YjWhuFWvTMDPfojWnES1BNtIB34wmG7NzvQoWykZJefnrJ6LtK
fny/QadUF/eUXrXarzgqlxGUx4wLnUNyrVrqUgWV/Ax6qddaXGMx+oXq/qAKRdr+
XSQDBPfOn9lmxhdUbXL4MjqLSQ/JbcOlq3MmZuJiLSQpp603BxFTPCUPLdTUq3Pz
ExfYstoZAJOj+zd+0JIPVuxJKDy3e5HwkzAVikpTysTIHYZRJykc08ooVRuZgCEW
tePvKzUgG3migPd2pLEWv2a2rVRpVlbV2p9H1cNVJ/S7ZH8uifdObG2ArhwgKm9I
O9f5WFjHw/jK5vQDqaZc609CpDc3QA9bHA2ynJOIaqUlix1xDyI8htf0EDINCcxS
K+MugkmIX16NL6ZQHVIWKB3sR1L9vonQ9zFIS/ANw4HWon3+77vRC9vlSziAoTle
QaAvupjVYEnEiGyRGGwWDiY1/62m4h3TUfYSDf0lfsO5YJf+PYAcq1El7GhEt1OK
K2enWvZHj07IOM0bfL/YnJGaNosffNlgMOsqjgLxUHB0VOT2Tm9UAiQCDlDOFDkR
OVQcfrb2c38xf4TaMfb/CW1S38qRQbENHzIojIak+IaRSrmVCZk=
=Blip
-----END PGP SIGNATURE-----
--=-=-=--