From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com ([192.55.52.115]:53396 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752784AbdDRM1Z (ORCPT ); Tue, 18 Apr 2017 08:27:25 -0400 From: Mika Kuoppala To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org Subject: Re: [PATCH] drm/i915: Fix system hang with EI UP masked on Haswell In-Reply-To: <20170413113715.GT12532@nuc-i3427.alporthouse.com> References: <1492082127-29007-1-git-send-email-mika.kuoppala@intel.com> <20170413113715.GT12532@nuc-i3427.alporthouse.com> Date: Tue, 18 Apr 2017 15:26:42 +0300 Message-ID: <878tmx52bh.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: stable-owner@vger.kernel.org List-ID: Chris Wilson writes: > On Thu, Apr 13, 2017 at 02:15:27PM +0300, Mika Kuoppala wrote: >> Previously with commit a9c1f90c8e17 >> ("drm/i915: Don't mask EI UP interrupt on IVB|SNB") certain, >> seemingly unrelated bit (GEN6_PM_RP_UP_EI_EXPIRED) was needed >> to be unmasked for IVB and SNB in order to prevent system hang >> with chained batchbuffers. >> >> Our CI was seeing incomplete results with tests that used >> chained batches and it was found out that HSW needs to have this >> same bit unmasked to reliably survive chained batches. >> >> Always unmask GEN6_PM_RP_UP_EI_EXPIRED on Haswell to >> prevent system hang with batch chaining. >> >> Testcase: igt/gem_exec_fence/nb-await-default >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100672 >> Cc: Chris Wilson >> Cc: stable@vger.kernel.org >> Signed-off-by: Mika Kuoppala > > * facepalm. > > I am amazed that took so long for us to notice. > Acked-by: Chris Wilson > Pushed to drm-intel-next-queued. Thanks. -Mika