From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com ([192.55.52.115]:8627 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751308AbcJDHoS (ORCPT ); Tue, 4 Oct 2016 03:44:18 -0400 From: Felipe Balbi To: ville.syrjala@linux.intel.com, linux-usb@vger.kernel.org Cc: stable@vger.kernel.org, Ville =?utf-8?B?U3lyasOkbMOk?= Subject: Re: [PATCH] Revert "usb: dwc3: gadget: use allocated/queued reqs for LST bit" In-Reply-To: <87lgy5za7o.fsf@linux.intel.com> References: <1475504282-13268-1-git-send-email-ville.syrjala@linux.intel.com> <87lgy5za7o.fsf@linux.intel.com> Date: Tue, 04 Oct 2016 10:43:48 +0300 Message-ID: <878tu4r22z.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: stable-owner@vger.kernel.org List-ID: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi again, Felipe Balbi writes: > ville.syrjala@linux.intel.com writes: >> From: Ville Syrj=C3=A4l=C3=A4 >> >> This reverts commit 55a0237f8f47957163125e20ee9260538c5c341c. >> >> commit 55a0237f8f47 ("usb: dwc3: gadget: use allocated/queued reqs for >> LST bit") causes my BYT FFRD8 with g_ether to behave poorly. ssh/scp >> is very sluggish and can even stall entirely. Revert cures it. >> >> Cc: Felipe Balbi >> Cc: stable@vger.kernel.org >> Signed-off-by: Ville Syrj=C3=A4l=C3=A4 > > Reverting that commit is not the best idea. Let's start with the usual: > > - Kernel version > - dmesg on both sides (host and device) > - dwc3 tracepoints: > > # mkdir -p /t > # mount -t tracefs none /t > # echo 8192 > /t/buffer_size_kb > # echo 1 > /t/events/dwc3/enable > # echo 0 > /t/events/dwc3/dwc3_readl/enable > # echo 0 > /t/events/dwc3/dwc3_writel/enable > > This should be enough to tell me what's really going on. I have been trying this with SKL running v4.8 vanilla and a laptop running v4.7.1 from Debian and I can't reproduce it. The only time when I sort of reproduced was when Network Manager on the laptop side decided to "reconfigure" the interface after I had ifconfig foobar 192.168.0.2, so the interface ended up loosing the IP. I have since configured that interface for static IP and it has been running for a while without any problems. FYI I sshed from laptop to SKL and have 'while true; do dmesg; done' running and in another terminal I'm pinging SKL from laptop. I'll keep it running for a while longer. Drop by once you're in the office and I can check what's going on with your device. cheers =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJX8120AAoJEMy+uJnhGpkGypIQAKpKrycRAL11c8eTo6rnRmHd wYZPJ1REb/BWdmcKhVsELG9rrBc99RDJlyooR2I4XohHroZjPa9qTCtjnhoc/Jiu aqVNATRB8J0xgGUjd4iPW1WZj48i8HvnRObseMdnF+mEk7/5KjiDEbuDO3UpBNBq 5RzoS/Nlrz4LOqpEz31ZHxKlSJDlD9YPtBD98bPGKA9q98Wj6bBpQeLMMrypsZ3V Qy+Tbi7XpUn7tl+7QOaFrwaINW+F9Zimmz9OLyjji8wknhyRwXSxgEnIg7ZDOkNf KB8lbSCM8BJRGMe/4G8Eo/x6a+5HtkRY76HY9WhyqKLUxxA8Y6pvzGsVWJcGw1kO CCWAD81ZjIYQTNsqG3q8AFa1ARZDY7Nx8LOEKKn8CmlueAdnchhEdemyy0pOapaK pAvGLX3fpeJA5PwYMZ2vajxLKd6zhfv3dSFECbcjirrt3w59uryVRjuzXWVJADqL 7/tqY6758InfrZEun1owoFqH91r7vL+QOH5E93Qe5TYXMeSRUvL8mVOu4WaG7VYb gz4bgqL9zrpoozJP4oN35WTt1On1lKq5E2kGRrnmBLUGhIqL8wfAwYhQPjXOXQGA eYYYoT72hBBoEPJkaDGXONas6BkxOIE/CFql24s0LsfqJopAyGledsDcRLJWbRKI um0c3i/tFjOAUPU7kixy =9hjg -----END PGP SIGNATURE----- --=-=-=--