From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from arroyo.ext.ti.com ([192.94.94.40]:51535 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932922AbbLHPR2 (ORCPT ); Tue, 8 Dec 2015 10:17:28 -0500 From: Felipe Balbi To: Bin Liu , Gregory CLEMENT CC: Greg Kroah-Hartman , , , , Subject: Re: [PATCH] usb: musb: dsps: handle the otg_state_a_wait_vrise_timeout case In-Reply-To: <5666EC67.7000203@ti.com> References: <1440087153-31084-1-git-send-email-gregory.clement@free-electrons.com> <55D719B1.8010700@free-electrons.com> <87twrfsbed.fsf@free-electrons.com> <87d1wtf5ir.fsf@saruman.tx.rr.com> <87a8rde96m.fsf@free-electrons.com> <87poyiegc7.fsf@free-electrons.com> <87poyinjpc.fsf@saruman.tx.rr.com> <874mft9ukx.fsf@free-electrons.com> <87h9jtm37m.fsf@saruman.tx.rr.com> <5666E9BE.5070907@ti.com> <87egexm2jr.fsf@saruman.tx.rr.com> <5666EC67.7000203@ti.com> Date: Tue, 8 Dec 2015 09:16:59 -0600 Message-ID: <878u55m0lw.fsf@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: stable-owner@vger.kernel.org List-ID: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Bin Liu writes: >>>>> "This bit should be set high prior to setting bit 0 and cleared after= bit 0 >>>>> is cleared." >>>>> >>>>> and on the other side: >>>>> "Both the soft_reset and soft_reset_isolation bits should be asserted >>>>> simultaneously." >>>>> >>>>> The hang you saw could be explained by the following: >>>>> "Setting only the soft_reset_isolation bit will cause all USB0 output >>>>> signals to go to a known constant value via multiplexers. >>>>> This will >>>>> prevent future access to USB0." page 2567 >>>> >>>> good catch. Setting them together makes the hang go away. >>>> >>>> I still have the other problem, which is legacy IRQ reporting mode not >>>> really working. >>>> >>> >>> I never tried to change the IRQ mapping. The 8 MUSB interrupt will be >>> the same no matter where they are reported from. What do you expect when >>> switch to the MUSB IRQ reporting mode? >> >> read events from MUSB's registers instead of TI's :-) so, MUSB_INTRUSB, >> MUSB_INTRRX and MUSB_INTRTX. >> > I meant you expect to see any different event when switch to MUSB IRQ=20 > mode? The TI wrapper just reports the same 8 interrupt events. I don't=20 > think you would get any difference. still valid to make sure ;-) > BTY, I think I miss some context here. This Gregory's patch is trying to= =20 > fix the OTG state machine problem in musb_dsps, which is replicated with= =20 > a cable without a device connected. But it also mentions about=20 > non-compliant MSC devices. How are the thumb drives related to this OTG=20 > state issue? the problem seems to be caused by the missing disconnect IRQ. Not really missing, but taking seconds to trigger. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWZvRrAAoJEIaOsuA1yqREXFoP/0K0tuq38wlfmjy67Vzw89Hk JWFA2QJ43dBKfBn7bu5k2N9ubCGSXTwbXKhYTxnxY5nbtWua6PdsOu5zhenYajao g2gkK/wRKLSGgLu7BNtFtVwhu2+jCjCrE2nS/lKJy7nJU8rVVT6XzHjS5PNlJYGN z9/EE0KI9K789kfl046XdB07umWQF3XwmE2q+4WZR3InjhscUWJKUPEvp77+ZLeR w+bwUE3q2ezYPc9UCGxn0HZczG46TKPqJ5DQUHQJeJlDJ2mBy1Sgioy/L+e2qFw5 J/Cc2p5jlKJAnG/5cn56H3g3/3BN6xYy9FqMac4PAjCSqz+njLzI4R7J7fB0i5IJ Fohi4/QfK95C1ob370M3tQOVFdHPDM/t7o9yoFLuc6XSBraxSfymc9+gJKNhlGAO FV0e8Lf2CmQMGX030HfPKNR98MjwGxl/+kYwokhXcRo5zvT5KZGykwPXEFQHav4I IpgVXPRZlcjzk69/kV4ke4jodZekarIh19tMsyh+76jFzoLKu3zmeWSLMHa5rc5A Jx6DU9h/poK8XWioPsd6PeA4mhVvzyQZtX7lnXyEztYFcd0lbioAoxdi9O+B/5O7 yvXRvwcgxMheLpjPjraWGD6/VYdMY56mJVUFMts1QVn6Um8YaLjxYij2ZWcZnCAt avlWIYZ93rgWK18PSWm9 =BCH6 -----END PGP SIGNATURE----- --=-=-=--