From: John Ogness <john.ogness@linutronix.de>
To: stable@vger.kernel.org, stable-commits@vger.kernel.org
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: Patch "serial: 8250: Switch to nbcon console, take 2" has been added to the 6.18-stable tree
Date: Tue, 17 Nov 2026 17:48:04 +0106 [thread overview]
Message-ID: <87a4n79zqb.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <20261117154343.1812289-1-sashal@kernel.org>
Hi,
On 2026-11-17, Sasha Levin <sashal@kernel.org> wrote:
> This is a note to let you know that I've just added the patch titled
>
> serial: 8250: Switch to nbcon console, take 2
>
> to the 6.18-stable tree which can be found at:
> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>
> The filename of the patch is:
> serial-8250-switch-to-nbcon-console-take-2.patch
> and it can be found in the queue-6.18 subdirectory.
>
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
Is this patch really needed for 6.18? The conversion to nbcon was
initially reverted for 6.14. The reason was it brought various serial
and 8250 issues into the foreground. It wasn't until these issues were
resolved (in 7.2) that it was allowed to convert the 8250 to nbcon.
If the 8250 nbcon is really needed for 6.18, then the set of uart/8250
fixes also need to be included. They probably apply, but it is a lot of
changes to put into stable if it is not explicitly needed.
The pre-requisite commits I am referring to:
9c7eb1c9c3e3 ("serial: core: Add dedicated uart_port field for console flow")
bf558715d91c ("serial: Replace driver usage of UPF_CONS_FLOW")
f69ec492244d ("serial: 8250: Set cons_flow on port registration")
39d307074f91 ("serial: 8250: Check LSR timeout on console flow control")
5e6dfb87b191 ("serial: 8250: Add support for console flow control")
302fbbb4fcbd ("serial: 8250: Ignore flow control on suspend/resume with no_console_suspend")
And then there were several fixes needed after the nbcon conversion:
560f4deda327 ("printk/nbcon: Change nbcon_irq_work to IRQ_WORK_LAZY")
37aba16e7943 ("serial: 8250: Change console_msr_work to IRQ_WORK_LAZY")
5f339c46f153 ("printk: Postpone kthread startup")
Let me know if I can help with any of this.
John Ogness
parent reply other threads:[~2026-11-17 16:42 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20261117154343.1812289-1-sashal@kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a4n79zqb.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox