From: Takashi Iwai <tiwai@suse.de>
To: Alexey Nepomnyashih <sdl@nppct.ru>
Cc: Clemens Ladisch <clemens@ladisch.de>,
Takashi Sakamoto <o-takashi@sakamocchi.jp>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org, stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: firewire-lib: fix uninitialized local variable
Date: Tue, 17 Mar 2026 09:55:02 +0100 [thread overview]
Message-ID: <87a4w6g7ix.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260316191824.83249-1-sdl@nppct.ru>
On Mon, 16 Mar 2026 20:18:22 +0100,
Alexey Nepomnyashih wrote:
>
> Similar to commit d8dc8720468a ("ALSA: firewire-lib: fix uninitialized
> local variable"), the local variable `curr_cycle_time` in
> process_rx_packets() is declared without initialization.
>
> When the tracepoint event is not probed, the variable may appear to be
> used without being initialized. In practice the value is only relevant
> when the tracepoint is enabled, however initializing it avoids potential
> use of an uninitialized value and improves code safety.
>
> Initialize `curr_cycle_time` to zero.
>
> Fixes: fef4e61b0b76 ("ALSA: firewire-lib: extend tracepoints event including CYCLE_TIME of 1394 OHCI")
> Cc: stable@vger.kernel.org
> Signed-off-by: Alexey Nepomnyashih <sdl@nppct.ru>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2026-03-17 8:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 19:18 [PATCH] ALSA: firewire-lib: fix uninitialized local variable Alexey Nepomnyashih
2026-03-17 8:55 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a4w6g7ix.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=clemens@ladisch.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=o-takashi@sakamocchi.jp \
--cc=perex@perex.cz \
--cc=sdl@nppct.ru \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox