public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jun Seo <junwoo93s@gmail.com>
Cc: tiwai@suse.com, perex@perex.cz, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Jun Seo <jun.seo.93@proton.me>
Subject: Re: [PATCH] ALSA: usb-audio: Use correct version for UAC3 header validation
Date: Thu, 26 Feb 2026 07:38:32 +0100	[thread overview]
Message-ID: <87a4wwc8lz.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260226010820.36529-1-jun.seo.93@proton.me>

On Thu, 26 Feb 2026 02:08:20 +0100,
Jun Seo wrote:
> 
> The entry of the validators table for UAC3 AC header descriptor is
> defined with the wrong protocol version UAC_VERSION_2, while it should
> have been UAC_VERSION_3.  This results in the validator never matching
> for actual UAC3 devices (protocol == UAC_VERSION_3), causing their
> header descriptors to bypass validation entirely.  A malicious USB
> device presenting a truncated UAC3 header could exploit this to cause
> out-of-bounds reads when the driver later accesses unvalidated
> descriptor fields.
> 
> The bug was introduced in the same commit as the recently fixed UAC3
> feature unit sub-type typo, and appears to be from the same copy-paste
> error when the UAC3 section was created from the UAC2 section.
> 
> Fixes: 57f8770620e9 ("ALSA: usb-audio: More validations of descriptor units")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Jun Seo <jun.seo.93@proton.me>

Thanks, applied now.


Takashi

      reply	other threads:[~2026-02-26  6:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26  1:08 [PATCH] ALSA: usb-audio: Use correct version for UAC3 header validation Jun Seo
2026-02-26  6:38 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a4wwc8lz.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=jun.seo.93@proton.me \
    --cc=junwoo93s@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox