* [PATCH RESEND] drm/xe/display: Add check for alloc_ordered_workqueue()
@ 2025-04-24 2:40 Haoxiang Li
2025-05-16 12:21 ` Jani Nikula
0 siblings, 1 reply; 2+ messages in thread
From: Haoxiang Li @ 2025-04-24 2:40 UTC (permalink / raw)
To: thomas.hellstrom, airlied, simona, maarten.lankhorst
Cc: intel-gfx, intel-xe, dri-devel, linux-kernel, Haoxiang Li, stable
Add check for the return value of alloc_ordered_workqueue()
in xe_display_create() to catch potential exception.
Fixes: 44e694958b95 ("drm/xe/display: Implement display support")
Cc: stable@vger.kernel.org
Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
---
drivers/gpu/drm/xe/display/xe_display.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
index 0b0aca7a25af..18062cfb265f 100644
--- a/drivers/gpu/drm/xe/display/xe_display.c
+++ b/drivers/gpu/drm/xe/display/xe_display.c
@@ -104,6 +104,8 @@ int xe_display_create(struct xe_device *xe)
spin_lock_init(&xe->display.fb_tracking.lock);
xe->display.hotplug.dp_wq = alloc_ordered_workqueue("xe-dp", 0);
+ if (!xe->display.hotplug.dp_wq)
+ return -ENOMEM;
return drmm_add_action_or_reset(&xe->drm, display_destroy, NULL);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] drm/xe/display: Add check for alloc_ordered_workqueue()
2025-04-24 2:40 [PATCH RESEND] drm/xe/display: Add check for alloc_ordered_workqueue() Haoxiang Li
@ 2025-05-16 12:21 ` Jani Nikula
0 siblings, 0 replies; 2+ messages in thread
From: Jani Nikula @ 2025-05-16 12:21 UTC (permalink / raw)
To: Haoxiang Li, thomas.hellstrom, airlied, simona, maarten.lankhorst
Cc: intel-gfx, intel-xe, dri-devel, linux-kernel, Haoxiang Li, stable
On Thu, 24 Apr 2025, Haoxiang Li <haoxiang_li2024@163.com> wrote:
> Add check for the return value of alloc_ordered_workqueue()
> in xe_display_create() to catch potential exception.
>
> Fixes: 44e694958b95 ("drm/xe/display: Implement display support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
This patch seems to have been neglected, apologies.
I've rebased it and included it as part of a bigger series [1].
Thanks for the patch.
BR,
Jani.
[1] https://lore.kernel.org/r/cover.1747397638.git.jani.nikula@intel.com
> ---
> drivers/gpu/drm/xe/display/xe_display.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
> index 0b0aca7a25af..18062cfb265f 100644
> --- a/drivers/gpu/drm/xe/display/xe_display.c
> +++ b/drivers/gpu/drm/xe/display/xe_display.c
> @@ -104,6 +104,8 @@ int xe_display_create(struct xe_device *xe)
> spin_lock_init(&xe->display.fb_tracking.lock);
>
> xe->display.hotplug.dp_wq = alloc_ordered_workqueue("xe-dp", 0);
> + if (!xe->display.hotplug.dp_wq)
> + return -ENOMEM;
>
> return drmm_add_action_or_reset(&xe->drm, display_destroy, NULL);
> }
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-16 12:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-24 2:40 [PATCH RESEND] drm/xe/display: Add check for alloc_ordered_workqueue() Haoxiang Li
2025-05-16 12:21 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox