Re: 答复: make a confirm for [usb: dwc3: gadget: skip Set/Clear Halt when invalid]

[Felipe Balbi <felipe.balbi@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 919 bytes --]


Hi,

Thinh Nguyen <thinh.nguyen@synopsys.com> writes:
>>> It means that the mainline keep checking stall status first before
>>> handle clear-halt request?  as usb spec, it's actually okay to send
>>> Clear Halt at any time. But dwc3 core hanging with macOS adb
>>> application, so I think there is other rootcase why dwc3 hanging , and
>>> current patch just for avoid this case. Right?
>> that's correct. There's another problem happening that causes dwc3 to
>> hang. I guess I'll just revert that patch since it causes more problems
>> than solve.
>>
>>> If someday WindonwPC/LINUX PC meet this case again liked my case,
>>> would you plan to revert it ? or other plan ?
>> I'll just revert it.
>>
>
> Do you plan to revert the patch ffb80fc672c3 ("usb: dwc3: gadget: skip
> Set/Clear Halt when invalid") for the next release?

I'll send a patch soon to be merged on -rc5 or so.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]