From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mga18.intel.com ([134.134.136.126]:32013 "EHLO mga18.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725908AbeKSQ6g (ORCPT <rfc822;stable@vger.kernel.org>);
        Mon, 19 Nov 2018 11:58:36 -0500
From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Thinh Nguyen <thinh.nguyen@synopsys.com>,
        liangshengjun <liangshengjun@hisilicon.com>,
        Alan Stern <stern@rowland.harvard.edu>
Cc: "stable\@vger.kernel.org" <stable@vger.kernel.org>,
        "linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
        John Youn <john.youn@synopsys.com>
Subject: Re: =?utf-8?B?562U5aSNOg==?= make a confirm for [usb: dwc3: gadget:
 skip Set/Clear Halt when invalid]
In-Reply-To: <30102591E157244384E984126FC3CB4F639A3016@us01wembx1.internal.synopsys.com>
References: <Pine.LNX.4.44L0.1806211127520.2381-100000@iolanthe.rowland.org> <878t73ux28.fsf@linux.intel.com> <84923CA334DF85428B9ADCEC0F3CE864BA1EA4@dggemm510-mbx.china.huawei.com> <874lhmf6zp.fsf@linux.intel.com> <30102591E157244384E984126FC3CB4F639A3016@us01wembx1.internal.synopsys.com>
Date: Mon, 19 Nov 2018 08:35:42 +0200
Message-ID: <87a7m5ingh.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Thinh Nguyen <thinh.nguyen@synopsys.com> writes:
>>> It means that the mainline keep checking stall status first before
>>> handle clear-halt request?  as usb spec, it's actually okay to send
>>> Clear Halt at any time. But dwc3 core hanging with macOS adb
>>> application, so I think there is other rootcase why dwc3 hanging , and
>>> current patch just for avoid this case. Right?
>> that's correct. There's another problem happening that causes dwc3 to
>> hang. I guess I'll just revert that patch since it causes more problems
>> than solve.
>>
>>> If someday WindonwPC/LINUX PC meet this case again liked my case,
>>> would you plan to revert it ? or other plan ?
>> I'll just revert it.
>>
>
> Do you plan to revert the patch ffb80fc672c3 ("usb: dwc3: gadget: skip
> Set/Clear Halt when invalid") for the next release?

I'll send a patch soon to be merged on -rc5 or so.

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlvyWcEACgkQzL64meEa
mQYobxAAgtRf5VJNBf2p2Y6MmUKE1Q6dyjcwyuI4cqDNl1lnHVOpKtcKbInlFAAd
2LCzEDO44GqXoiCtm4jy/6ZRfKg5oV4RrcxIljhPeixUsQj15nzSMoR1jW9LhwlQ
cz+c6QzjxM07QGsVKwossFTl4qcImPdpJ0DGZ9hlZmbM8RnR4WbbWBEuTT7N+ozN
7ovY3h3/P3DLHbfsvww/qE0ZkQMoaWsGJ4SKQITZaN4Yv4Htq7UR0AfhlzkiH6NB
3tmLtaMtof0bdJZcvSnEgy7wjglTIXu/JFg7D4c6iR9+H1pbJRrgVMG+oZaVe2ze
LJcvExi9lfpzJllExXcfvVS8RY1C1We8T+s4OwP+uUrdYlt8iXmWKlKFgA9nrNiD
5/Y7HPv+xPdoE8wpotU/muqfqWROVy4HJhJSNWfFexrkQGuYBzr9UXdDKL+ujkxM
VFDdYHtS/EAOu8MGpmZwbyad7qjePaPzzgAq77v+xTxYWS9qqN6qb0rSTtJXuozI
nIHD99DB8r3RA8w12RNdMBxdV10tjYPVUbet+uUEWlrDFJLuxrsZRqucG6o6OpiF
xxIt7kYRBtcZIEtY/UDQKa3oVZEQKRWYQmY+xQscyTFTJ18W56p3aP+dIyn8CT63
mjjhyjmPkjUF4C7tiD+Ki8qLh3ygZpucAuYv4CqgRaiwYdsmfXU=
=EijV
-----END PGP SIGNATURE-----
--=-=-=--