Re: [PATCH v2 1/3] drm/xe: Read out rawclk_freq for display

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 20 Aug 2024, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Mon, 19 Aug 2024, Maarten Lankhorst <maarten.lankhorst@linux.intel.com> wrote:
>> Failing to read out rawclk makes it impossible to read out backlight,
>> which results in backlight not working when the backlight is off during
>> boot, or when reloading the module.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Fixes: 44e694958b95 ("drm/xe/display: Implement display support")
>> Cc: <stable@vger.kernel.org> # v6.8+
>
> Please find another way. See [1]. I'm trying to clean up the whole
> RUNTIME_INFO() and rawclk_freq thing, and this makes it harder.

Had another look, and brushed up my old patches, new version at [1].

BR,
Jani.


[1] https://lore.kernel.org/r/cover.1724144570.git.jani.nikula@intel.com


>
> BR,
> Jani.
>
>
> [1] https://lore.kernel.org/r/ddd05f84ca4a6597133bee55ddf4ab593a16e99d.1717672515.git.jani.nikula@intel.com
>
>> ---
>>  drivers/gpu/drm/xe/display/xe_display.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
>> index 30dfdac9f6fa9..79add15c6c4c7 100644
>> --- a/drivers/gpu/drm/xe/display/xe_display.c
>> +++ b/drivers/gpu/drm/xe/display/xe_display.c
>> @@ -159,6 +159,9 @@ int xe_display_init_noirq(struct xe_device *xe)
>>  
>>  	intel_display_device_info_runtime_init(xe);
>>  
>> +	RUNTIME_INFO(xe)->rawclk_freq = intel_read_rawclk(xe);
>> +	drm_dbg(&xe->drm, "rawclk rate: %d kHz\n", RUNTIME_INFO(xe)->rawclk_freq);
>> +
>>  	err = intel_display_driver_probe_noirq(xe);
>>  	if (err) {
>>  		intel_opregion_cleanup(display);

-- 
Jani Nikula, Intel