* [PATCH v2 1/3] drm/xe: Read out rawclk_freq for display [not found] <20240819133138.147511-1-maarten.lankhorst@linux.intel.com> @ 2024-08-19 13:31 ` Maarten Lankhorst 2024-08-20 7:43 ` Jani Nikula 0 siblings, 1 reply; 3+ messages in thread From: Maarten Lankhorst @ 2024-08-19 13:31 UTC (permalink / raw) To: intel-xe; +Cc: Maarten Lankhorst, stable Failing to read out rawclk makes it impossible to read out backlight, which results in backlight not working when the backlight is off during boot, or when reloading the module. Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Fixes: 44e694958b95 ("drm/xe/display: Implement display support") Cc: <stable@vger.kernel.org> # v6.8+ --- drivers/gpu/drm/xe/display/xe_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c index 30dfdac9f6fa9..79add15c6c4c7 100644 --- a/drivers/gpu/drm/xe/display/xe_display.c +++ b/drivers/gpu/drm/xe/display/xe_display.c @@ -159,6 +159,9 @@ int xe_display_init_noirq(struct xe_device *xe) intel_display_device_info_runtime_init(xe); + RUNTIME_INFO(xe)->rawclk_freq = intel_read_rawclk(xe); + drm_dbg(&xe->drm, "rawclk rate: %d kHz\n", RUNTIME_INFO(xe)->rawclk_freq); + err = intel_display_driver_probe_noirq(xe); if (err) { intel_opregion_cleanup(display); -- 2.45.2 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/3] drm/xe: Read out rawclk_freq for display 2024-08-19 13:31 ` [PATCH v2 1/3] drm/xe: Read out rawclk_freq for display Maarten Lankhorst @ 2024-08-20 7:43 ` Jani Nikula 2024-08-20 9:12 ` Jani Nikula 0 siblings, 1 reply; 3+ messages in thread From: Jani Nikula @ 2024-08-20 7:43 UTC (permalink / raw) To: Maarten Lankhorst, intel-xe; +Cc: Maarten Lankhorst, stable On Mon, 19 Aug 2024, Maarten Lankhorst <maarten.lankhorst@linux.intel.com> wrote: > Failing to read out rawclk makes it impossible to read out backlight, > which results in backlight not working when the backlight is off during > boot, or when reloading the module. > > Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Fixes: 44e694958b95 ("drm/xe/display: Implement display support") > Cc: <stable@vger.kernel.org> # v6.8+ Please find another way. See [1]. I'm trying to clean up the whole RUNTIME_INFO() and rawclk_freq thing, and this makes it harder. BR, Jani. [1] https://lore.kernel.org/r/ddd05f84ca4a6597133bee55ddf4ab593a16e99d.1717672515.git.jani.nikula@intel.com > --- > drivers/gpu/drm/xe/display/xe_display.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c > index 30dfdac9f6fa9..79add15c6c4c7 100644 > --- a/drivers/gpu/drm/xe/display/xe_display.c > +++ b/drivers/gpu/drm/xe/display/xe_display.c > @@ -159,6 +159,9 @@ int xe_display_init_noirq(struct xe_device *xe) > > intel_display_device_info_runtime_init(xe); > > + RUNTIME_INFO(xe)->rawclk_freq = intel_read_rawclk(xe); > + drm_dbg(&xe->drm, "rawclk rate: %d kHz\n", RUNTIME_INFO(xe)->rawclk_freq); > + > err = intel_display_driver_probe_noirq(xe); > if (err) { > intel_opregion_cleanup(display); -- Jani Nikula, Intel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/3] drm/xe: Read out rawclk_freq for display 2024-08-20 7:43 ` Jani Nikula @ 2024-08-20 9:12 ` Jani Nikula 0 siblings, 0 replies; 3+ messages in thread From: Jani Nikula @ 2024-08-20 9:12 UTC (permalink / raw) To: Maarten Lankhorst, intel-xe; +Cc: Maarten Lankhorst, stable On Tue, 20 Aug 2024, Jani Nikula <jani.nikula@linux.intel.com> wrote: > On Mon, 19 Aug 2024, Maarten Lankhorst <maarten.lankhorst@linux.intel.com> wrote: >> Failing to read out rawclk makes it impossible to read out backlight, >> which results in backlight not working when the backlight is off during >> boot, or when reloading the module. >> >> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> >> Fixes: 44e694958b95 ("drm/xe/display: Implement display support") >> Cc: <stable@vger.kernel.org> # v6.8+ > > Please find another way. See [1]. I'm trying to clean up the whole > RUNTIME_INFO() and rawclk_freq thing, and this makes it harder. Had another look, and brushed up my old patches, new version at [1]. BR, Jani. [1] https://lore.kernel.org/r/cover.1724144570.git.jani.nikula@intel.com > > BR, > Jani. > > > [1] https://lore.kernel.org/r/ddd05f84ca4a6597133bee55ddf4ab593a16e99d.1717672515.git.jani.nikula@intel.com > >> --- >> drivers/gpu/drm/xe/display/xe_display.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c >> index 30dfdac9f6fa9..79add15c6c4c7 100644 >> --- a/drivers/gpu/drm/xe/display/xe_display.c >> +++ b/drivers/gpu/drm/xe/display/xe_display.c >> @@ -159,6 +159,9 @@ int xe_display_init_noirq(struct xe_device *xe) >> >> intel_display_device_info_runtime_init(xe); >> >> + RUNTIME_INFO(xe)->rawclk_freq = intel_read_rawclk(xe); >> + drm_dbg(&xe->drm, "rawclk rate: %d kHz\n", RUNTIME_INFO(xe)->rawclk_freq); >> + >> err = intel_display_driver_probe_noirq(xe); >> if (err) { >> intel_opregion_cleanup(display); -- Jani Nikula, Intel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-20 9:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240819133138.147511-1-maarten.lankhorst@linux.intel.com>
2024-08-19 13:31 ` [PATCH v2 1/3] drm/xe: Read out rawclk_freq for display Maarten Lankhorst
2024-08-20 7:43 ` Jani Nikula
2024-08-20 9:12 ` Jani Nikula
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox