From: Jani Nikula <jani.nikula@intel.com>
To: Ander Conselvan De Oliveira <conselvan2@gmail.com>,
intel-gfx@lists.freedesktop.org
Cc: Daniel Nicoletti <dantti12@gmail.com>, stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: quirk backlight present on Macbook 4, 1
Date: Mon, 16 Nov 2015 14:49:36 +0200 [thread overview]
Message-ID: <87bnauf6sf.fsf@intel.com> (raw)
In-Reply-To: <1447059473.5942.0.camel@gmail.com>
On Mon, 09 Nov 2015, Ander Conselvan De Oliveira <conselvan2@gmail.com> wrote:
> Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>
Pushed to drm-intel-fixes, thanks for the review.
BR,
Jani.
>
> On Thu, 2015-11-05 at 11:49 +0200, Jani Nikula wrote:
>> Unsurprisingly macbooks have backlights, just the VBT doesn't seem to
>> know it in this case.
>>
>> Reported-and-tested-by: Daniel Nicoletti <dantti12@gmail.com>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88325
>> Fixes: c675949ec58c ("drm/i915: do not setup backlight if not available
>> according to VBT")
>> Cc: stable@vger.kernel.org # v3.15+
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_display.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_display.c
>> b/drivers/gpu/drm/i915/intel_display.c
>> index 7b3cfb64e7f6..b067147183e9 100644
>> --- a/drivers/gpu/drm/i915/intel_display.c
>> +++ b/drivers/gpu/drm/i915/intel_display.c
>> @@ -14875,6 +14875,9 @@ static struct intel_quirk intel_quirks[] = {
>> /* Apple Macbook 2,1 (Core 2 T7400) */
>> { 0x27a2, 0x8086, 0x7270, quirk_backlight_present },
>>
>> + /* Apple Macbook 4,1 */
>> + { 0x2a02, 0x106b, 0x00a1, quirk_backlight_present },
>> +
>> /* Toshiba CB35 Chromebook (Celeron 2955U) */
>> { 0x0a06, 0x1179, 0x0a88, quirk_backlight_present },
>>
--
Jani Nikula, Intel Open Source Technology Center
prev parent reply other threads:[~2015-11-16 12:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 9:49 [PATCH] drm/i915: quirk backlight present on Macbook 4,1 Jani Nikula
2015-11-09 8:57 ` [Intel-gfx] [PATCH] drm/i915: quirk backlight present on Macbook 4, 1 Ander Conselvan De Oliveira
2015-11-16 12:49 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnauf6sf.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=conselvan2@gmail.com \
--cc=dantti12@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).