From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com ([134.134.136.20]:18791 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751481AbbHQHiZ (ORCPT ); Mon, 17 Aug 2015 03:38:25 -0400 From: Jani Nikula To: Daniel Vetter , Chris Wilson Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: Flag the execlists context object as dirty after every use In-Reply-To: <20150814121822.GY17734@phenom.ffwll.local> References: <1439553559-23004-1-git-send-email-chris@chris-wilson.co.uk> <20150814121822.GY17734@phenom.ffwll.local> Date: Mon, 17 Aug 2015 10:39:53 +0300 Message-ID: <87bne6pdme.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: stable-owner@vger.kernel.org List-ID: On Fri, 14 Aug 2015, Daniel Vetter wrote: > On Fri, Aug 14, 2015 at 12:59:19PM +0100, Chris Wilson wrote: >> Everytime we use the logical context with execlists it becomes dirty (as >> the hardware will write the new register values afterwards, as well as >> the GPU state that will be used). We need to then flag the context as >> dirty everytime since after a swap-out/swap-in cycle the dirty flag will >> be cleared, and a further swap-out cycle will then loose the most recent >> GPU state. >> >> Signed-off-by: Chris Wilson >> Cc: stable@vger.kernel.org > > Yay for reinventing active tracking I guess, legacy hw ctx has this > already. Reviewed-by: Daniel Vetter Pushed to drm-intel-fixes, thanks for the patch and review. BR, Jani. > -Daniel >> --- >> drivers/gpu/drm/i915/intel_lrc.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c >> index 138964afd187..41cfa6fa909d 100644 >> --- a/drivers/gpu/drm/i915/intel_lrc.c >> +++ b/drivers/gpu/drm/i915/intel_lrc.c >> @@ -1013,6 +1013,8 @@ static int intel_lr_context_pin(struct drm_i915_gem_request *rq) >> ret = intel_pin_and_map_ringbuffer_obj(ring->dev, ringbuf); >> if (ret) >> goto unpin_ctx_obj; >> + >> + ctx_obj->dirty = true; >> } >> >> return ret; >> -- >> 2.5.0 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center