Re: [PATCH] ASoC: soc-ops: Correct the max value for clamp in soc_mixer_reg_to_ctl()

["Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>]

On 17/12/2025 15:16, Richard Fitzgerald wrote:
> On 17/12/2025 1:01 pm, Péter Ujfalusi wrote:
>>
>>
>> On 17/12/2025 14:40, Richard Fitzgerald wrote:
>>>>
>>>> It passes my manual tests on cs42l43, not sure how to run the unit-test
>>>> for SX, can you by chance test this?
>>>>
>>> The easiest option is to run them from your kernel build tree like this:
>>
>> It is in my to-do list to get kunit working on my setups (Artix Linux on
>> dev and DUTs), so it is really something that will take rest of the year
>> easily ;)
>>
>>>
>>> make mrproper
>>> ./tools/testing/kunit/kunit.py run --kunitconfig=tools/testing/kunit/
>>> configs/all_tests.config
>>
>>>
>>
> The kunit tests can run on the computer you use to build the kernel. It
> takes a couple of minutes to run.
> 
> On my desktop box with vanilla 6.19-rc1:
> 
> rf@debianbox:~/work/kernel/linux$ make mrproper
> rf@debianbox:~/work/kernel/linux$ time ./tools/testing/kunit/kunit.py
> run --alltests

well, I don't have kunit test setup, so it fails, but I can build the
kernel and install on DUT and load the module:
[  159.843361]         ok 97 single volsw_sx: 0,0 -> range: 15->4(0), sign: 0, inv: 0 -> 0xf,0x0
[  159.843499]     # soc_ops_test_access: EXPECTATION FAILED at sound/soc/soc-ops-test.c:520
                   Expected result->value.integer.value[0] == param->lctl, but
                       result->value.integer.value[0] == 0 (0x0)
                       param->lctl == 1 (0x1)
[  159.843641]         not ok 98 single volsw_sx: 1,1 -> range: 15->4(0), sign: 0, inv: 0 -> 0x0,0x0

I guess, this implies that this patch is indeed does not work.

Tested the other patch and that works, sent my tested-by for it.

> 
> <SNIP>
> 
> [13:12:31] Testing complete. Ran 7154 tests: passed: 7082, failed: 36,
> skipped: 36
> [13:12:31] Elapsed time: 110.250s total, 3.072s configuring, 55.003s
> building, 52.119s running
> 
> real    1m50.314s
> user    15m52.878s
> sys    1m18.186s
> 

-- 
Péter