From: Jonathan Corbet <corbet@lwn.net>
To: Randy Dunlap <rdunlap@infradead.org>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Linux Doc Mailing List <linux-doc@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jani Nikula <jani.nikula@intel.com>,
Shuah Khan <skhan@linuxfoundation.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v4 2/4] scripts/kernel-doc: avoid error_count overflows
Date: Fri, 16 Jan 2026 11:17:28 -0700 [thread overview]
Message-ID: <87ecnpo213.fsf@trenco.lwn.net> (raw)
In-Reply-To: <79bb75da-5233-46d8-9590-7443806e2bd7@infradead.org>
Randy Dunlap <rdunlap@infradead.org> writes:
> Mauro,
> The line formatting is weird on one line below
> (looks like 2 text lines are joined).
>
> On 1/14/26 4:57 AM, Mauro Carvalho Chehab wrote:
>> The glibc library limits the return code to 8 bits. We need to
>> stick to this limit when using sys.exit(error_count).
>>
>> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
>> Cc: stable@vger.kernel.org
>> ---
>> scripts/kernel-doc.py | 25 ++++++++++++++++++-------
>> 1 file changed, 18 insertions(+), 7 deletions(-)
>>
>> diff --git a/scripts/kernel-doc.py b/scripts/kernel-doc.py
>> index 7a1eaf986bcd..3992ca49d593 100755
>> --- a/scripts/kernel-doc.py
>> +++ b/scripts/kernel-doc.py
>> @@ -116,6 +116,8 @@ SRC_DIR = os.path.dirname(os.path.realpath(__file__))
>>
>> sys.path.insert(0, os.path.join(SRC_DIR, LIB_DIR))
>>
>> +WERROR_RETURN_CODE = 3
>> +
>> DESC = """
>> Read C language source or header FILEs, extract embedded documentation comments,
>> and print formatted documentation to standard output.
>> @@ -176,7 +178,20 @@ class MsgFormatter(logging.Formatter):
>> return logging.Formatter.format(self, record)
>>
>> def main():
>> - """Main program"""
>> + """
>> + Main program
>> + By default, the return value is:
>> +
>> + - 0: success or Python version is not compatible with kernel-doc. If -Werror is not used, it will also
>
> Here ^^^^^
>
Mauro, can you get me a clean copy? It seems like we're more than ready
to apply this set otherwise...
Thanks,
jon
next prev parent reply other threads:[~2026-01-16 18:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1768395332.git.mchehab+huawei@kernel.org>
2026-01-14 12:57 ` [PATCH v4 1/4] scripts/kernel-doc: fix logic to handle unissued warnings Mauro Carvalho Chehab
2026-01-14 12:57 ` [PATCH v4 2/4] scripts/kernel-doc: avoid error_count overflows Mauro Carvalho Chehab
2026-01-15 0:43 ` Randy Dunlap
2026-01-16 18:17 ` Jonathan Corbet [this message]
2026-01-17 9:52 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ecnpo213.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=jani.nikula@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox