public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: usb-audio: apply quirk for Huawei Technologies Co., Ltd. CM-Q3
@ 2025-10-11  9:51 Cryolitia PukNgae
  2025-10-11  9:52 ` kernel test robot
  2025-10-11 10:50 ` Takashi Iwai
  0 siblings, 2 replies; 3+ messages in thread
From: Cryolitia PukNgae @ 2025-10-11  9:51 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai, Cryolitia PukNgae
  Cc: linux-sound, linux-kernel, stable, zhanjun, niecheng1, anguoli,
	zhaochengyi, fengyuan, Cryolitia PukNgae

There're several different actual hardwares sold by Huawei, using the
same USB ID 12d1:3a07.

The first one we found, having a volume control named "Headset Playback
Volume", reports a min value -15360, and will mute iff setting it to
-15360. It can be simply fixed by quirk flag MIXER_PLAYBACK_MIN_MUTE,
which we have already submitted previously.[1]

The second one we found today, having a volume control named "PCM
Playback Volume", reports its min -11520 and res 256, and will mute
when less than -11008. Because of the already existing quirk flag, we
can just set its min to -11264, and the new minimum value will still
not be available to userspace, so that userspace's minimum will be the
correct -11008.

1. https://lore.kernel.org/all/20250903-sound-v1-3-d4ca777b8512@uniontech.com/

Tested-by: Guoli An <anguoli@uniontech.com>
Signed-off-by: Cryolitia PukNgae <cryolitia.pukngae@linux.dev>
---
 sound/usb/mixer.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
index 34bcbfd8b54e66abc0229eefd354eb7bc4c01576..ae412e651faf905c9f7d600de8e19c51995cd3f9 100644
--- a/sound/usb/mixer.c
+++ b/sound/usb/mixer.c
@@ -1189,6 +1189,13 @@ static void volume_control_quirks(struct usb_mixer_elem_info *cval,
 			cval->min = -14208; /* Mute under it */
 		}
 		break;
+	case USB_ID(0x12d1, 0x3a07): /* Huawei Technologies Co., Ltd. CM-Q3 */
+		if (!strcmp(kctl->id.name, "PCM Playback Volume")) {
+			usb_audio_info(chip,
+				       "set volume quirk for Huawei Technologies Co., Ltd. CM-Q3\n");
+			cval->min = -11264; /* Mute under it */
+		}
+		break;
 	}
 }
 

---
base-commit: 7e9827afc78073096149cf3565ba668fe2ef4831
change-id: 20251011-sound_quirk-6a8326325451

Best regards,
-- 
Cryolitia PukNgae <cryolitia.pukngae@linux.dev>



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ALSA: usb-audio: apply quirk for Huawei Technologies Co., Ltd. CM-Q3
  2025-10-11  9:51 [PATCH] ALSA: usb-audio: apply quirk for Huawei Technologies Co., Ltd. CM-Q3 Cryolitia PukNgae
@ 2025-10-11  9:52 ` kernel test robot
  2025-10-11 10:50 ` Takashi Iwai
  1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2025-10-11  9:52 UTC (permalink / raw)
  To: Cryolitia PukNgae; +Cc: stable, oe-kbuild-all

Hi,

Thanks for your patch.

FYI: kernel test robot notices the stable kernel rule is not satisfied.

The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-1

Rule: add the tag "Cc: stable@vger.kernel.org" in the sign-off area to have the patch automatically included in the stable tree.
Subject: [PATCH] ALSA: usb-audio: apply quirk for Huawei Technologies Co., Ltd. CM-Q3
Link: https://lore.kernel.org/stable/20251011-sound_quirk-v1-1-d693738108ee%40linux.dev

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ALSA: usb-audio: apply quirk for Huawei Technologies Co., Ltd. CM-Q3
  2025-10-11  9:51 [PATCH] ALSA: usb-audio: apply quirk for Huawei Technologies Co., Ltd. CM-Q3 Cryolitia PukNgae
  2025-10-11  9:52 ` kernel test robot
@ 2025-10-11 10:50 ` Takashi Iwai
  1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2025-10-11 10:50 UTC (permalink / raw)
  To: Cryolitia PukNgae
  Cc: Jaroslav Kysela, Takashi Iwai, Cryolitia PukNgae, linux-sound,
	linux-kernel, stable, zhanjun, niecheng1, anguoli, zhaochengyi,
	fengyuan

On Sat, 11 Oct 2025 11:51:18 +0200,
Cryolitia PukNgae wrote:
> 
> There're several different actual hardwares sold by Huawei, using the
> same USB ID 12d1:3a07.
> 
> The first one we found, having a volume control named "Headset Playback
> Volume", reports a min value -15360, and will mute iff setting it to
> -15360. It can be simply fixed by quirk flag MIXER_PLAYBACK_MIN_MUTE,
> which we have already submitted previously.[1]
> 
> The second one we found today, having a volume control named "PCM
> Playback Volume", reports its min -11520 and res 256, and will mute
> when less than -11008. Because of the already existing quirk flag, we
> can just set its min to -11264, and the new minimum value will still
> not be available to userspace, so that userspace's minimum will be the
> correct -11008.
> 
> 1. https://lore.kernel.org/all/20250903-sound-v1-3-d4ca777b8512@uniontech.com/
> 
> Tested-by: Guoli An <anguoli@uniontech.com>
> Signed-off-by: Cryolitia PukNgae <cryolitia.pukngae@linux.dev>

Thanks, applied now.


Takashi

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-10-11 10:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-11  9:51 [PATCH] ALSA: usb-audio: apply quirk for Huawei Technologies Co., Ltd. CM-Q3 Cryolitia PukNgae
2025-10-11  9:52 ` kernel test robot
2025-10-11 10:50 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox