* [PATCH] ALSA: hda/realtek: fix mute/micmute LED For HP mt645
@ 2024-02-14 18:45 Alexandru Gagniuc
2024-02-15 12:49 ` Takashi Iwai
0 siblings, 1 reply; 8+ messages in thread
From: Alexandru Gagniuc @ 2024-02-14 18:45 UTC (permalink / raw)
To: linux-sound, perex, tiwai
Cc: linux-kernel, eniac-xw.zhang, Eniac Zhang, Alexandru Gagniuc,
Alexandru Gagniuc, stable
From: Eniac Zhang <eniacz@gmail.com>
The HP mt645 G7 Thin Client uses an ALC236 codec and needs the
ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk to make the mute and
micmute LEDs work.
There are two variants of the USB-C PD chip on this device. Each uses
a different BIOS and board ID, hence the two entries.
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Signed-off-by: Alexandru Gagniuc <alexandru.gagniuc@hp.com>
Cc: <stable@vger.kernel.org>
---
sound/pci/hda/patch_realtek.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 6994c4c5073c..c837470ef5b8 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9928,6 +9928,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8abb, "HP ZBook Firefly 14 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b0f, "HP Elite mt645 G7 Mobile Thin Client U81", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x8b2f, "HP 255 15.6 inch G10 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
SND_PCI_QUIRK(0x103c, 0x8b42, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8b43, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
@@ -9935,6 +9936,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8b45, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8b46, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8b47, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b59, "HP Elite mt645 G7 Mobile Thin Client U89", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x8b5d, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x8b5e, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x8b63, "HP Elite Dragonfly 13.5 inch G4", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED),
--
2.42.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: fix mute/micmute LED For HP mt645
2024-02-14 18:45 [PATCH] ALSA: hda/realtek: fix mute/micmute LED For HP mt645 Alexandru Gagniuc
@ 2024-02-15 12:49 ` Takashi Iwai
2024-02-15 15:25 ` Zhang, Eniac
0 siblings, 1 reply; 8+ messages in thread
From: Takashi Iwai @ 2024-02-15 12:49 UTC (permalink / raw)
To: Alexandru Gagniuc
Cc: linux-sound, perex, tiwai, linux-kernel, eniac-xw.zhang,
Eniac Zhang, Alexandru Gagniuc, stable
On Wed, 14 Feb 2024 19:45:07 +0100,
Alexandru Gagniuc wrote:
>
> From: Eniac Zhang <eniacz@gmail.com>
>
> The HP mt645 G7 Thin Client uses an ALC236 codec and needs the
> ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk to make the mute and
> micmute LEDs work.
>
> There are two variants of the USB-C PD chip on this device. Each uses
> a different BIOS and board ID, hence the two entries.
>
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
> Signed-off-by: Alexandru Gagniuc <alexandru.gagniuc@hp.com>
Any reason to have two your sign-offs?
Also, can we get a sign-off from the original author?
thanks,
Takashi
> Cc: <stable@vger.kernel.org>
> ---
> sound/pci/hda/patch_realtek.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 6994c4c5073c..c837470ef5b8 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9928,6 +9928,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x8abb, "HP ZBook Firefly 14 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> + SND_PCI_QUIRK(0x103c, 0x8b0f, "HP Elite mt645 G7 Mobile Thin Client U81", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> SND_PCI_QUIRK(0x103c, 0x8b2f, "HP 255 15.6 inch G10 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
> SND_PCI_QUIRK(0x103c, 0x8b42, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8b43, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> @@ -9935,6 +9936,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x8b45, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8b46, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8b47, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> + SND_PCI_QUIRK(0x103c, 0x8b59, "HP Elite mt645 G7 Mobile Thin Client U89", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> SND_PCI_QUIRK(0x103c, 0x8b5d, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> SND_PCI_QUIRK(0x103c, 0x8b5e, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> SND_PCI_QUIRK(0x103c, 0x8b63, "HP Elite Dragonfly 13.5 inch G4", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED),
> --
> 2.42.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] ALSA: hda/realtek: fix mute/micmute LED For HP mt645
2024-02-15 12:49 ` Takashi Iwai
@ 2024-02-15 15:25 ` Zhang, Eniac
2024-02-15 15:27 ` Takashi Iwai
0 siblings, 1 reply; 8+ messages in thread
From: Zhang, Eniac @ 2024-02-15 15:25 UTC (permalink / raw)
To: Takashi Iwai, Gagniuc, Alexandru
Cc: linux-sound@vger.kernel.org, perex@perex.cz, tiwai@suse.com,
linux-kernel@vger.kernel.org, Eniac Zhang, Alexandru Gagniuc,
stable@vger.kernel.org
Hi Takashi,
I can sign off this merge request. Alex is ThinPro's new kernel maintainer. He is trying to push all those old HP patches upstream to make our life (and other HP machine user's life) easier.
Let me know if there's anything else I can do.
Regards/Eniac
-----Original Message-----
From: Takashi Iwai <tiwai@suse.de>
Sent: Thursday, February 15, 2024 5:50 AM
To: Gagniuc, Alexandru <alexandru.gagniuc@hp.com>
Cc: linux-sound@vger.kernel.org; perex@perex.cz; tiwai@suse.com; linux-kernel@vger.kernel.org; Zhang, Eniac <eniac-xw.zhang@hp.com>; Eniac Zhang <eniacz@gmail.com>; Alexandru Gagniuc <mr.nuke.me@gmail.com>; stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: fix mute/micmute LED For HP mt645
CAUTION: External Email
On Wed, 14 Feb 2024 19:45:07 +0100,
Alexandru Gagniuc wrote:
>
> From: Eniac Zhang <eniacz@gmail.com>
>
> The HP mt645 G7 Thin Client uses an ALC236 codec and needs the
> ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk to make the mute and
> micmute LEDs work.
>
> There are two variants of the USB-C PD chip on this device. Each uses
> a different BIOS and board ID, hence the two entries.
>
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
> Signed-off-by: Alexandru Gagniuc <alexandru.gagniuc@hp.com>
Any reason to have two your sign-offs?
Also, can we get a sign-off from the original author?
thanks,
Takashi
> Cc: <stable@vger.kernel.org>
> ---
> sound/pci/hda/patch_realtek.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c
> b/sound/pci/hda/patch_realtek.c index 6994c4c5073c..c837470ef5b8
> 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9928,6 +9928,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x8abb, "HP ZBook Firefly 14 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9
> Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> + SND_PCI_QUIRK(0x103c, 0x8b0f, "HP Elite mt645 G7 Mobile Thin
> + Client U81", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> SND_PCI_QUIRK(0x103c, 0x8b2f, "HP 255 15.6 inch G10 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
> SND_PCI_QUIRK(0x103c, 0x8b42, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8b43, "HP",
> ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> @@ -9935,6 +9936,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x8b45, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8b46, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8b47, "HP",
> ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> + SND_PCI_QUIRK(0x103c, 0x8b59, "HP Elite mt645 G7 Mobile Thin
> + Client U89", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> SND_PCI_QUIRK(0x103c, 0x8b5d, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> SND_PCI_QUIRK(0x103c, 0x8b5e, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> SND_PCI_QUIRK(0x103c, 0x8b63, "HP Elite Dragonfly 13.5 inch G4",
> ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED),
> --
> 2.42.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: fix mute/micmute LED For HP mt645
2024-02-15 15:25 ` Zhang, Eniac
@ 2024-02-15 15:27 ` Takashi Iwai
2024-02-15 15:49 ` [PATCH v2] " Alexandru Gagniuc
2024-02-20 17:58 ` [PATCH] ALSA: hda/realtek: fix mute/micmute LED For HP mt440 Alexandru Gagniuc
0 siblings, 2 replies; 8+ messages in thread
From: Takashi Iwai @ 2024-02-15 15:27 UTC (permalink / raw)
To: Zhang, Eniac
Cc: Takashi Iwai, Gagniuc, Alexandru, linux-sound@vger.kernel.org,
perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org,
Eniac Zhang, Alexandru Gagniuc, stable@vger.kernel.org
On Thu, 15 Feb 2024 16:25:05 +0100,
Zhang, Eniac wrote:
>
> Hi Takashi,
>
> I can sign off this merge request. Alex is ThinPro's new kernel maintainer. He is trying to push all those old HP patches upstream to make our life (and other HP machine user's life) easier.
>
> Let me know if there's anything else I can do.
Yes, your sign-off is appreciated.
Also, let's have only one sign-off from Alex (that matches with the
submission mail address) for avoiding confusion.
Please resubmit with those two things addressed.
thanks,
Takashi
>
> Regards/Eniac
>
> -----Original Message-----
> From: Takashi Iwai <tiwai@suse.de>
> Sent: Thursday, February 15, 2024 5:50 AM
> To: Gagniuc, Alexandru <alexandru.gagniuc@hp.com>
> Cc: linux-sound@vger.kernel.org; perex@perex.cz; tiwai@suse.com; linux-kernel@vger.kernel.org; Zhang, Eniac <eniac-xw.zhang@hp.com>; Eniac Zhang <eniacz@gmail.com>; Alexandru Gagniuc <mr.nuke.me@gmail.com>; stable@vger.kernel.org
> Subject: Re: [PATCH] ALSA: hda/realtek: fix mute/micmute LED For HP mt645
>
> CAUTION: External Email
>
> On Wed, 14 Feb 2024 19:45:07 +0100,
> Alexandru Gagniuc wrote:
> >
> > From: Eniac Zhang <eniacz@gmail.com>
> >
> > The HP mt645 G7 Thin Client uses an ALC236 codec and needs the
> > ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk to make the mute and
> > micmute LEDs work.
> >
> > There are two variants of the USB-C PD chip on this device. Each uses
> > a different BIOS and board ID, hence the two entries.
> >
> > Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
> > Signed-off-by: Alexandru Gagniuc <alexandru.gagniuc@hp.com>
>
> Any reason to have two your sign-offs?
> Also, can we get a sign-off from the original author?
>
>
> thanks,
>
> Takashi
>
> > Cc: <stable@vger.kernel.org>
> > ---
> > sound/pci/hda/patch_realtek.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/sound/pci/hda/patch_realtek.c
> > b/sound/pci/hda/patch_realtek.c index 6994c4c5073c..c837470ef5b8
> > 100644
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -9928,6 +9928,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> > SND_PCI_QUIRK(0x103c, 0x8abb, "HP ZBook Firefly 14 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> > SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> > SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9
> > Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> > + SND_PCI_QUIRK(0x103c, 0x8b0f, "HP Elite mt645 G7 Mobile Thin
> > + Client U81", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> > SND_PCI_QUIRK(0x103c, 0x8b2f, "HP 255 15.6 inch G10 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
> > SND_PCI_QUIRK(0x103c, 0x8b42, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> > SND_PCI_QUIRK(0x103c, 0x8b43, "HP",
> > ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> > @@ -9935,6 +9936,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> > SND_PCI_QUIRK(0x103c, 0x8b45, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> > SND_PCI_QUIRK(0x103c, 0x8b46, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> > SND_PCI_QUIRK(0x103c, 0x8b47, "HP",
> > ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> > + SND_PCI_QUIRK(0x103c, 0x8b59, "HP Elite mt645 G7 Mobile Thin
> > + Client U89", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> > SND_PCI_QUIRK(0x103c, 0x8b5d, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> > SND_PCI_QUIRK(0x103c, 0x8b5e, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> > SND_PCI_QUIRK(0x103c, 0x8b63, "HP Elite Dragonfly 13.5 inch G4",
> > ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED),
> > --
> > 2.42.0
> >
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] ALSA: hda/realtek: fix mute/micmute LED For HP mt645
2024-02-15 15:27 ` Takashi Iwai
@ 2024-02-15 15:49 ` Alexandru Gagniuc
2024-02-15 15:59 ` Takashi Iwai
2024-02-20 17:58 ` [PATCH] ALSA: hda/realtek: fix mute/micmute LED For HP mt440 Alexandru Gagniuc
1 sibling, 1 reply; 8+ messages in thread
From: Alexandru Gagniuc @ 2024-02-15 15:49 UTC (permalink / raw)
To: linux-sound, perex, tiwai
Cc: linux-kernel, eniac-xw.zhang, Alexandru Gagniuc, stable
From: Eniac Zhang <eniac-xw.zhang@hp.com>
The HP mt645 G7 Thin Client uses an ALC236 codec and needs the
ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk to make the mute and
micmute LEDs work.
There are two variants of the USB-C PD chip on this device. Each uses
a different BIOS and board ID, hence the two entries.
Signed-off-by: Eniac Zhang <eniac-xw.zhang@hp.com>
Signed-off-by: Alexandru Gagniuc <alexandru.gagniuc@hp.com>
Cc: <stable@vger.kernel.org>
---
Changes since version 1:
- Adjusted Signed-off-by lines to include original author.
sound/pci/hda/patch_realtek.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 6994c4c5073c..c837470ef5b8 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9928,6 +9928,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8abb, "HP ZBook Firefly 14 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b0f, "HP Elite mt645 G7 Mobile Thin Client U81", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x8b2f, "HP 255 15.6 inch G10 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
SND_PCI_QUIRK(0x103c, 0x8b42, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8b43, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
@@ -9935,6 +9936,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8b45, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8b46, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8b47, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8b59, "HP Elite mt645 G7 Mobile Thin Client U89", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x8b5d, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x8b5e, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x8b63, "HP Elite Dragonfly 13.5 inch G4", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED),
--
2.42.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ALSA: hda/realtek: fix mute/micmute LED For HP mt645
2024-02-15 15:49 ` [PATCH v2] " Alexandru Gagniuc
@ 2024-02-15 15:59 ` Takashi Iwai
0 siblings, 0 replies; 8+ messages in thread
From: Takashi Iwai @ 2024-02-15 15:59 UTC (permalink / raw)
To: Alexandru Gagniuc
Cc: linux-sound, perex, tiwai, linux-kernel, eniac-xw.zhang, stable
On Thu, 15 Feb 2024 16:49:22 +0100,
Alexandru Gagniuc wrote:
>
> From: Eniac Zhang <eniac-xw.zhang@hp.com>
>
> The HP mt645 G7 Thin Client uses an ALC236 codec and needs the
> ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk to make the mute and
> micmute LEDs work.
>
> There are two variants of the USB-C PD chip on this device. Each uses
> a different BIOS and board ID, hence the two entries.
>
> Signed-off-by: Eniac Zhang <eniac-xw.zhang@hp.com>
> Signed-off-by: Alexandru Gagniuc <alexandru.gagniuc@hp.com>
> Cc: <stable@vger.kernel.org>
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ALSA: hda/realtek: fix mute/micmute LED For HP mt440
2024-02-15 15:27 ` Takashi Iwai
2024-02-15 15:49 ` [PATCH v2] " Alexandru Gagniuc
@ 2024-02-20 17:58 ` Alexandru Gagniuc
2024-02-21 10:15 ` Takashi Iwai
1 sibling, 1 reply; 8+ messages in thread
From: Alexandru Gagniuc @ 2024-02-20 17:58 UTC (permalink / raw)
To: linux-sound, perex, tiwai
Cc: linux-kernel, eniac-xw.zhang, Alexandru Gagniuc, stable
From: Eniac Zhang <eniac-xw.zhang@hp.com>
The HP mt440 Thin Client uses an ALC236 codec and needs the
ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk to make the mute and
micmute LEDs work.
There are two variants of the USB-C PD chip on this device. Each uses
a different BIOS and board ID, hence the two entries.
Signed-off-by: Eniac Zhang <eniac-xw.zhang@hp.com>
Signed-off-by: Alexandru Gagniuc <alexandru.gagniuc@hp.com>
Cc: <stable@vger.kernel.org>
---
sound/pci/hda/patch_realtek.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 0ec1312bffd5..f1b204d34928 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9902,6 +9902,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8973, "HP EliteBook 860 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8974, "HP EliteBook 840 Aero G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8975, "HP EliteBook x360 840 Aero G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x897d, "HP mt440 Mobile Thin Client U74", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8981, "HP Elite Dragonfly G3", ALC245_FIXUP_CS35L41_SPI_4),
SND_PCI_QUIRK(0x103c, 0x898e, "HP EliteBook 835 G9", ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x103c, 0x898f, "HP EliteBook 835 G9", ALC287_FIXUP_CS35L41_I2C_2),
@@ -9932,6 +9933,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8b0f, "HP Elite mt645 G7 Mobile Thin Client U81", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
SND_PCI_QUIRK(0x103c, 0x8b2f, "HP 255 15.6 inch G10 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
+ SND_PCI_QUIRK(0x103c, 0x8b3f, "HP mt440 Mobile Thin Client U91", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8b42, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8b43, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8b44, "HP", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
--
2.42.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: fix mute/micmute LED For HP mt440
2024-02-20 17:58 ` [PATCH] ALSA: hda/realtek: fix mute/micmute LED For HP mt440 Alexandru Gagniuc
@ 2024-02-21 10:15 ` Takashi Iwai
0 siblings, 0 replies; 8+ messages in thread
From: Takashi Iwai @ 2024-02-21 10:15 UTC (permalink / raw)
To: Alexandru Gagniuc
Cc: linux-sound, perex, tiwai, linux-kernel, eniac-xw.zhang, stable
On Tue, 20 Feb 2024 18:58:12 +0100,
Alexandru Gagniuc wrote:
>
> From: Eniac Zhang <eniac-xw.zhang@hp.com>
>
> The HP mt440 Thin Client uses an ALC236 codec and needs the
> ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk to make the mute and
> micmute LEDs work.
>
> There are two variants of the USB-C PD chip on this device. Each uses
> a different BIOS and board ID, hence the two entries.
>
> Signed-off-by: Eniac Zhang <eniac-xw.zhang@hp.com>
> Signed-off-by: Alexandru Gagniuc <alexandru.gagniuc@hp.com>
> Cc: <stable@vger.kernel.org>
Thanks, applied now.
But at the next time, don't hang on the existing thread when
submitting a new patch.
Takashi
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-02-21 10:15 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-14 18:45 [PATCH] ALSA: hda/realtek: fix mute/micmute LED For HP mt645 Alexandru Gagniuc
2024-02-15 12:49 ` Takashi Iwai
2024-02-15 15:25 ` Zhang, Eniac
2024-02-15 15:27 ` Takashi Iwai
2024-02-15 15:49 ` [PATCH v2] " Alexandru Gagniuc
2024-02-15 15:59 ` Takashi Iwai
2024-02-20 17:58 ` [PATCH] ALSA: hda/realtek: fix mute/micmute LED For HP mt440 Alexandru Gagniuc
2024-02-21 10:15 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox