From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Kenneth Graunke <kenneth@whitecape.org>, stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Disable SAMPLER_STATE prefetching on all Gen11 steppings.
Date: Tue, 25 Jun 2019 12:48:22 +0300 [thread overview]
Message-ID: <87ef3i572x.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20190625090655.19220-1-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> From: Kenneth Graunke <kenneth@whitecape.org>
>
> The Demand Prefetch workaround (binding table prefetching) only applies
> to Icelake A0/B0. But the Sampler Prefetch workaround needs to be
> applied to all Gen11 steppings, according to a programming note in the
> SARCHKMD documentation.
>
> Using the Intel Gallium driver, I have seen intermittent failures in
> the dEQP-GLES31.functional.copy_image.non_compressed.* tests. After
> applying this workaround, the tests reliably pass.
>
> v2: Remove the overlap with a pre-production w/a
>
> BSpec: 9663
> Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: stable@vger.kernel.org
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index c70445adfb02..993804d09517 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -1252,8 +1252,12 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
> if (IS_ICL_REVID(i915, ICL_REVID_A0, ICL_REVID_B0))
> wa_write_or(wal,
> GEN7_SARCHKMD,
> - GEN7_DISABLE_DEMAND_PREFETCH |
> - GEN7_DISABLE_SAMPLER_PREFETCH);
> + GEN7_DISABLE_DEMAND_PREFETCH);
> +
> + /* Wa_1606682166:icl */
> + wa_write_or(wal,
> + GEN7_SARCHKMD,
> + GEN7_DISABLE_SAMPLER_PREFETCH);
> }
>
> if (IS_GEN_RANGE(i915, 9, 11)) {
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-06-25 9:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 7:08 [PATCH] drm/i915: Disable SAMPLER_STATE prefetching on all Gen11 steppings Kenneth Graunke
2019-06-25 9:06 ` Chris Wilson
2019-06-25 9:48 ` Mika Kuoppala [this message]
2019-06-25 10:13 ` [Intel-gfx] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef3i572x.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kenneth@whitecape.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).