From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com ([192.55.52.93]:21916 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752796AbbJMNy3 (ORCPT ); Tue, 13 Oct 2015 09:54:29 -0400 From: Jani Nikula To: Daniel Vetter Cc: Chris Wilson , Daniel Vetter , intel-gfx@lists.freedesktop.org, stable@vger.kernel.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: Flush pipecontrol post-sync writes In-Reply-To: <20151013133724.GY26718@phenom.ffwll.local> References: <1440169721-25861-1-git-send-email-chris@chris-wilson.co.uk> <20150826091634.GQ20434@phenom.ffwll.local> <20150826092924.GD17184@nuc-i3427.alporthouse.com> <87612b543d.fsf@intel.com> <20151013133724.GY26718@phenom.ffwll.local> Date: Tue, 13 Oct 2015 16:57:54 +0300 Message-ID: <87eggy50rh.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: stable-owner@vger.kernel.org List-ID: On Tue, 13 Oct 2015, Daniel Vetter wrote: > On Tue, Oct 13, 2015 at 03:45:58PM +0300, Jani Nikula wrote: >> On Wed, 26 Aug 2015, Chris Wilson wrote: >> > On Wed, Aug 26, 2015 at 11:16:34AM +0200, Daniel Vetter wrote: >> >> On Fri, Aug 21, 2015 at 04:08:41PM +0100, Chris Wilson wrote: >> >> > In order to flush the results from in-batch pipecontrol writes (used for >> >> > example in glQuery) before declaring the batch complete (and so declaring >> >> > the query results coherent), we need to set the FlushEnable bit in our >> >> > flushing pipecontrol. The FlushEnable bit "waits until all previous >> >> > writes of immediate data from post-sync circles are complete before >> >> > executing the next command". >> >> > >> >> > Signed-off-by: Chris Wilson >> >> > Cc: stable@vger.kernel.org >> >> >> >> Do we have an igt/piglit failing somewhere (igt kinda preferred) or a >> >> bugzilla or why is this cc: stable? >> > >> > I get GPU hangs on byt without flushing these writes (running ue4). >> > piglit has examples where the flush is required for correct rendering. >> >> Daniel, does this satisfy your question? We've had an r-b from Ville for >> a long time. > > Yeah, just add that bit to the commit message to justify cc: stable. Pushed to drm-intel-fixes, thanks for the patch and review. BR, Jani. > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch -- Jani Nikula, Intel Open Source Technology Center